Welcome to mirror list, hosted at ThFree Co, Russian Federation.

github.com/stefan-niedermann/nextcloud-deck.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Niedermann <info@niedermann.it>2022-11-03 17:56:41 +0300
committerStefan Niedermann <info@niedermann.it>2022-11-03 17:56:41 +0300
commit6a14c4f6ce235807241694f0290f3bd2f312bfc2 (patch)
tree6150a426a427900cc1b9a46a364d12c77d7eed47
parente783b61c8cd94ff12aaad36ee5752fb63bde5a1a (diff)
Fix #1356 NullPointerException on CoordinatorLayout
Signed-off-by: Stefan Niedermann <info@niedermann.it>
-rw-r--r--app/src/main/java/it/niedermann/nextcloud/deck/ui/MainActivity.java10
-rw-r--r--fastlane/metadata/android/en-US/changelogs/1021000.txt1
2 files changed, 8 insertions, 3 deletions
diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/MainActivity.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/MainActivity.java
index 51378f290..7e25beeb9 100644
--- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/MainActivity.java
+++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/MainActivity.java
@@ -1112,9 +1112,13 @@ public class MainActivity extends AppCompatActivity implements DeleteStackListen
@AnyThread
private void showSyncFailedSnackbar(@NonNull Throwable throwable) {
if (!(throwable instanceof NextcloudHttpRequestFailedException) || ((NextcloudHttpRequestFailedException) throwable).getStatusCode() != HttpURLConnection.HTTP_UNAVAILABLE) {
- runOnUiThread(() -> BrandedSnackbar.make(binding.coordinatorLayout, R.string.synchronization_failed, Snackbar.LENGTH_LONG)
- .setAction(R.string.simple_more, v -> ExceptionDialogFragment.newInstance(throwable, mainViewModel.getCurrentAccount()).show(getSupportFragmentManager(), ExceptionDialogFragment.class.getSimpleName()))
- .show());
+ runOnUiThread(() -> {
+ if (binding != null) { // Can be null in case the activity has been destroyed before the synchronization process has been finished
+ BrandedSnackbar.make(binding.coordinatorLayout, R.string.synchronization_failed, Snackbar.LENGTH_LONG)
+ .setAction(R.string.simple_more, v -> ExceptionDialogFragment.newInstance(throwable, mainViewModel.getCurrentAccount()).show(getSupportFragmentManager(), ExceptionDialogFragment.class.getSimpleName()))
+ .show();
+ }
+ });
}
}
diff --git a/fastlane/metadata/android/en-US/changelogs/1021000.txt b/fastlane/metadata/android/en-US/changelogs/1021000.txt
index 8488a78cf..4e03e4176 100644
--- a/fastlane/metadata/android/en-US/changelogs/1021000.txt
+++ b/fastlane/metadata/android/en-US/changelogs/1021000.txt
@@ -1 +1,2 @@
- 🐞 Create new list: Dialog does not close (#1361)
+- 🐞 NullPointerException on CoordinatorLayout (#1356)