diff options
author | Stefan Niedermann <info@niedermann.it> | 2024-01-22 16:32:26 +0300 |
---|---|---|
committer | Stefan Niedermann <info@niedermann.it> | 2024-01-22 16:32:26 +0300 |
commit | 2a6872d25b05d4b600d2e01e7257d506560a9439 (patch) | |
tree | 005ccdb37e21ffa2c5a514fa2a61d58c0a60d076 /app/src/main/java/it/niedermann/nextcloud/deck/remote | |
parent | b8c1f9a5af5497613b7cd1b87afe47b3d281cb8c (diff) |
chore(lint): Use Object.equals where possible
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Diffstat (limited to 'app/src/main/java/it/niedermann/nextcloud/deck/remote')
3 files changed, 6 insertions, 7 deletions
diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/AbstractSyncDataProvider.java b/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/AbstractSyncDataProvider.java index 4347af0b5..89974602a 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/AbstractSyncDataProvider.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/AbstractSyncDataProvider.java @@ -18,7 +18,7 @@ import it.niedermann.nextcloud.deck.remote.helpers.SyncHelper; public abstract class AbstractSyncDataProvider<T extends IRemoteEntity> { @Nullable - protected AbstractSyncDataProvider<?> parent; + protected final AbstractSyncDataProvider<?> parent; protected final List<AbstractSyncDataProvider<?>> children = new ArrayList<>(); protected boolean stillGoingDeeper = false; diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/AttachmentDataProvider.java b/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/AttachmentDataProvider.java index 09ad2c81b..07ad054f7 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/AttachmentDataProvider.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/AttachmentDataProvider.java @@ -21,10 +21,10 @@ import it.niedermann.nextcloud.deck.remote.api.ResponseCallback; public class AttachmentDataProvider extends AbstractSyncDataProvider<Attachment> { - private FullCard card; - private Board board; - private Stack stack; - private List<Attachment> attachments; + private final FullCard card; + private final Board board; + private final Stack stack; + private final List<Attachment> attachments; public AttachmentDataProvider(AbstractSyncDataProvider<?> parent, Board board, Stack stack, FullCard card, List<Attachment> attachments) { super(parent); diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/StackDataProvider.java b/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/StackDataProvider.java index 16eea8692..dda38764c 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/StackDataProvider.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/remote/helpers/providers/StackDataProvider.java @@ -106,8 +106,7 @@ public class StackDataProvider extends AbstractSyncDataProvider<FullStack> { // so we can just skip this one and proceed with cards. return Collections.emptyList(); } - List<FullStack> changedStacks = dataBaseAdapter.getLocallyChangedStacksForBoard(accountId, board.getLocalId()); - return changedStacks; + return dataBaseAdapter.getLocallyChangedStacksForBoard(accountId, board.getLocalId()); } @Override |