fix: Recreate MainActivity after changing any setting to directly apply them

Signed-off-by: Stefan Niedermann <info@niedermann.it>

2 files changed, 3 insertions, 3 deletions

diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/settings/SettingsActivity.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/settings/SettingsActivity.java
index 172b31fd1..0ca0739fe 100644
--- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/settings/SettingsActivity.java
+++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/settings/SettingsActivity.java
@@ -35,7 +35,9 @@ public class SettingsActivity extends AppCompatActivity implements Themed {
         applyTheme(account.getColor());
         setSupportActionBar(binding.toolbar);
         setContentView(binding.getRoot());
-        setResult(RESULT_CANCELED);
+
+        // TODO We should only set this if a preference has changed that influences the MainActivity
+        setResult(RESULT_OK);
     }
 
     @Override
diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/settings/SettingsFragment.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/settings/SettingsFragment.java
index 422095497..44cfe5410 100644
--- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/settings/SettingsFragment.java
+++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/settings/SettingsFragment.java
@@ -1,6 +1,5 @@
 package it.niedermann.nextcloud.deck.ui.settings;
 
-import android.app.Activity;
 import android.os.Bundle;
 import android.view.View;
 
@@ -66,7 +65,6 @@ public class SettingsFragment extends PreferenceFragmentCompat {
         if (themePref != null) {
             themePref.setOnPreferenceChangeListener((Preference preference, Object newValue) -> {
                 preferencesViewModel.setAppTheme(Integer.parseInt((String) newValue));
-                requireActivity().setResult(Activity.RESULT_OK);
                 ActivityCompat.recreate(requireActivity());
                 return true;
             });