diff options
author | Stefan Niedermann <info@niedermann.it> | 2022-01-10 12:44:08 +0300 |
---|---|---|
committer | Stefan Niedermann <info@niedermann.it> | 2022-01-10 12:44:08 +0300 |
commit | 4d6958e057c9ec94aa10f78cc77be1e880043a99 (patch) | |
tree | 5340c65b9ca2ab7c94842eaed9598bd8971fc4df /app/src/main/java | |
parent | c13c48f3eea2e4637821b604661e521a426df531 (diff) |
Reset bindings to null onDestroy
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Diffstat (limited to 'app/src/main/java')
8 files changed, 55 insertions, 10 deletions
diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentContributingTab.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentContributingTab.java index 8b0c18a7a..17965e1aa 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentContributingTab.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentContributingTab.java @@ -13,12 +13,20 @@ import it.niedermann.nextcloud.deck.databinding.FragmentAboutContributionTabBind public class AboutFragmentContributingTab extends Fragment { + private FragmentAboutContributionTabBinding binding; + @Override public View onCreateView(@NonNull LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) { - FragmentAboutContributionTabBinding binding = FragmentAboutContributionTabBinding.inflate(inflater, container, false); + binding = FragmentAboutContributionTabBinding.inflate(inflater, container, false); binding.aboutSource.setText(getString(R.string.about_source, getString(R.string.url_source))); binding.aboutIssues.setText(getString(R.string.about_issues, getString(R.string.url_issues))); binding.aboutTranslate.setText(getString(R.string.about_translate, getString(R.string.url_translations))); return binding.getRoot(); } + + @Override + public void onDestroy() { + super.onDestroy(); + this.binding = null; + } }
\ No newline at end of file diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentCreditsTab.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentCreditsTab.java index 6dac2a2a1..0491b70a6 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentCreditsTab.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentCreditsTab.java @@ -1,5 +1,10 @@ package it.niedermann.nextcloud.deck.ui.about; +import static it.niedermann.nextcloud.deck.util.SpannableUtil.disabled; +import static it.niedermann.nextcloud.deck.util.SpannableUtil.setTextWithURL; +import static it.niedermann.nextcloud.deck.util.SpannableUtil.strong; +import static it.niedermann.nextcloud.deck.util.SpannableUtil.url; + import android.content.SharedPreferences; import android.os.Bundle; import android.text.method.LinkMovementMethod; @@ -18,11 +23,6 @@ import it.niedermann.nextcloud.deck.databinding.FragmentAboutCreditsTabBinding; import it.niedermann.nextcloud.deck.model.Account; import it.niedermann.nextcloud.deck.util.DateUtil; -import static it.niedermann.nextcloud.deck.util.SpannableUtil.disabled; -import static it.niedermann.nextcloud.deck.util.SpannableUtil.setTextWithURL; -import static it.niedermann.nextcloud.deck.util.SpannableUtil.strong; -import static it.niedermann.nextcloud.deck.util.SpannableUtil.url; - public class AboutFragmentCreditsTab extends Fragment { private static final String BUNDLE_KEY_ACCOUNT = "account"; @@ -63,6 +63,12 @@ public class AboutFragmentCreditsTab extends Fragment { return binding.getRoot(); } + @Override + public void onDestroy() { + super.onDestroy(); + this.binding = null; + } + public static Fragment newInstance() { return new AboutFragmentCreditsTab(); } diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentLicenseTab.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentLicenseTab.java index 5e7b7a1ec..39a30ec2e 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentLicenseTab.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/about/AboutFragmentLicenseTab.java @@ -1,5 +1,9 @@ package it.niedermann.nextcloud.deck.ui.about; +import static it.niedermann.nextcloud.deck.DeckApplication.isDarkTheme; +import static it.niedermann.nextcloud.deck.util.DeckColorUtil.contrastRatioIsSufficientBigAreas; +import static it.niedermann.nextcloud.deck.util.SpannableUtil.setTextWithURL; + import android.content.Intent; import android.content.res.ColorStateList; import android.graphics.Color; @@ -21,10 +25,6 @@ import it.niedermann.nextcloud.deck.DeckApplication; import it.niedermann.nextcloud.deck.R; import it.niedermann.nextcloud.deck.databinding.FragmentAboutLicenseTabBinding; -import static it.niedermann.nextcloud.deck.DeckApplication.isDarkTheme; -import static it.niedermann.nextcloud.deck.util.DeckColorUtil.contrastRatioIsSufficientBigAreas; -import static it.niedermann.nextcloud.deck.util.SpannableUtil.setTextWithURL; - public class AboutFragmentLicenseTab extends Fragment { private FragmentAboutLicenseTabBinding binding; @@ -49,4 +49,10 @@ public class AboutFragmentLicenseTab extends Fragment { binding.aboutAppLicenseButton.setTextColor(ColorUtil.INSTANCE.getForegroundColorForBackgroundColor(finalMainColor)); }); } + + @Override + public void onDestroy() { + super.onDestroy(); + this.binding = null; + } }
\ No newline at end of file diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/activities/CardActivityFragment.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/activities/CardActivityFragment.java index d00ce05dd..c204b1658 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/activities/CardActivityFragment.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/activities/CardActivityFragment.java @@ -48,4 +48,10 @@ public class CardActivityFragment extends Fragment { })); return binding.getRoot(); } + + @Override + public void onDestroy() { + super.onDestroy(); + this.binding = null; + } } diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/CardAttachmentsFragment.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/CardAttachmentsFragment.java index 8ddb0add9..48fbc3ea7 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/CardAttachmentsFragment.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/attachments/CardAttachmentsFragment.java @@ -393,6 +393,7 @@ public class CardAttachmentsFragment extends Fragment implements AttachmentDelet this.binding.pickerRecyclerView.setAdapter(null); } super.onDestroy(); + this.binding = null; } private void uploadNewAttachmentFromUri(@NonNull Uri sourceUri, String mimeType) throws UploadAttachmentFailedException { diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/comments/CardCommentsFragment.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/comments/CardCommentsFragment.java index 08ef5cdf1..7e90e513a 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/comments/CardCommentsFragment.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/comments/CardCommentsFragment.java @@ -135,6 +135,12 @@ public class CardCommentsFragment extends Fragment implements CommentEditedListe } @Override + public void onDestroy() { + super.onDestroy(); + this.binding = null; + } + + @Override public void onCommentEdited(Long id, String comment) { commentsViewModel.updateComment(mainViewModel.getAccount().getId(), mainViewModel.getFullCard().getLocalId(), id, comment); } diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java index 11b565cb3..b21f2f7ad 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java @@ -116,6 +116,12 @@ public class CardDetailsFragment extends Fragment implements OnDateSetListener, if (dpd != null) dpd.setOnDateSetListener(this); } + @Override + public void onDestroy() { + super.onDestroy(); + this.binding = null; + } + private void applyBrand(@ColorInt int boardColor) { // TODO apply correct branding on the BrandedDatePicker applyBrandToEditTextInputLayout(boardColor, binding.labelsWrapper); diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/filter/FilterDialogFragment.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/filter/FilterDialogFragment.java index 94101fff9..a06a1c8f4 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/filter/FilterDialogFragment.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/filter/FilterDialogFragment.java @@ -97,6 +97,12 @@ public class FilterDialogFragment extends BrandedDialogFragment { .create(); } + @Override + public void onDestroy() { + super.onDestroy(); + this.binding = null; + } + public static DialogFragment newInstance() { return new FilterDialogFragment(); } |