diff options
author | Stefan Niedermann <info@niedermann.it> | 2021-05-26 17:15:01 +0300 |
---|---|---|
committer | Stefan Niedermann <info@niedermann.it> | 2021-05-26 17:15:01 +0300 |
commit | 93c5018c5cb926755dea7524a621ed4b9d4d7ae7 (patch) | |
tree | 511547d514dd8a8209cb53a14659d71c31892f20 /app/src | |
parent | 15f29a3ab0f55f4dc0d5f96aa5b06f3ef522e243 (diff) |
Do not hide edit button when description is empty and one is in preview mode #971
Signed-off-by: Stefan Niedermann <info@niedermann.it>
Diffstat (limited to 'app/src')
-rw-r--r-- | app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java index 57316a40b..d827ba9ac 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/ui/card/details/CardDetailsFragment.java @@ -133,10 +133,10 @@ public class CardDetailsFragment extends Fragment implements OnDateSetListener, binding.descriptionViewer.setMovementMethod(LinkMovementMethod.getInstance()); viewModel.descriptionIsPreviewMode().observe(getViewLifecycleOwner(), (isPreview) -> { if (isPreview) { - toggleView(binding.descriptionViewer, binding.descriptionEditorWrapper, binding.descriptionViewer); + toggleEditorView(isPreview, binding.descriptionViewer, binding.descriptionEditorWrapper, binding.descriptionViewer); binding.descriptionToggle.setImageResource(R.drawable.ic_edit_grey600_24dp); } else { - toggleView(binding.descriptionEditorWrapper, binding.descriptionViewer, binding.descriptionEditor); + toggleEditorView(isPreview, binding.descriptionEditorWrapper, binding.descriptionViewer, binding.descriptionEditor); binding.descriptionToggle.setImageResource(R.drawable.ic_baseline_eye_24); } }); @@ -150,7 +150,7 @@ public class CardDetailsFragment extends Fragment implements OnDateSetListener, } } - private void toggleView(@NonNull View viewToShow, @NonNull View viewToHide, @NonNull MarkdownEditor editorToShow) { + private void toggleEditorView(boolean isPreview, @NonNull View viewToShow, @NonNull View viewToHide, @NonNull MarkdownEditor editorToShow) { editorToShow.setMarkdownString(viewModel.getFullCard().getCard().getDescription()); if (!editorToShow.getMarkdownString().hasActiveObservers()) { editorToShow.getMarkdownString().observe(getViewLifecycleOwner(), (description) -> { @@ -159,7 +159,7 @@ public class CardDetailsFragment extends Fragment implements OnDateSetListener, } else { ExceptionDialogFragment.newInstance(new IllegalStateException(FullCard.class.getSimpleName() + " was empty when trying to setup description"), viewModel.getAccount()).show(getChildFragmentManager(), ExceptionDialogFragment.class.getSimpleName()); } - binding.descriptionToggle.setVisibility(TextUtils.isEmpty(description) ? INVISIBLE : VISIBLE); + binding.descriptionToggle.setVisibility(TextUtils.isEmpty(description) && !isPreview ? INVISIBLE : VISIBLE); }); } viewToHide.setVisibility(GONE); |