From 1027c67c681159a3326d2bcec0095a32608d6d11 Mon Sep 17 00:00:00 2001 From: Stefan Niedermann Date: Tue, 3 Aug 2021 15:53:37 +0200 Subject: Replaced explicit types with diamond operator Signed-off-by: Stefan Niedermann --- .../nextcloud/deck/api/RequestHelper.java | 2 +- .../nextcloud/deck/api/ResponseCallback.java | 4 +- .../nextcloud/deck/model/ocs/Version.java | 6 +-- .../deck/persistence/sync/SyncManager.java | 48 ++++++++--------- .../sync/adapters/db/util/LiveDataHelper.java | 8 +-- .../adapters/db/util/extrawurst/Debouncer.java | 2 +- .../db/util/extrawurst/UserSearchLiveData.java | 2 +- .../sync/helpers/DataPropagationHelper.java | 6 +-- .../deck/persistence/sync/helpers/SyncHelper.java | 6 +-- .../providers/AccessControlDataProvider.java | 6 +-- .../helpers/providers/AttachmentDataProvider.java | 2 +- .../sync/helpers/providers/CardDataProvider.java | 14 ++--- .../providers/CardPropagationDataProvider.java | 4 +- .../providers/DeckCommentsDataProvider.java | 5 +- .../sync/helpers/providers/LabelDataProvider.java | 2 +- .../helpers/providers/OcsProjectDataProvider.java | 2 +- .../nextcloud/deck/ui/ImportAccountActivity.java | 10 ++-- .../niedermann/nextcloud/deck/ui/MainActivity.java | 22 ++++---- .../nextcloud/deck/ui/PickStackActivity.java | 12 ++--- .../deck/ui/PushNotificationActivity.java | 8 +-- .../ui/archivedboards/ArchivedBoardsActvitiy.java | 6 +-- .../ui/archivedcards/ArchivedCardsAdapter.java | 4 +- .../deck/ui/attachments/AttachmentViewHolder.java | 2 +- .../accesscontrol/AccessControlDialogFragment.java | 12 ++--- .../managelabels/ManageLabelsDialogFragment.java | 12 ++--- .../nextcloud/deck/ui/card/CardAdapter.java | 4 +- .../card/attachments/CardAttachmentsFragment.java | 4 +- .../ui/card/comments/CardCommentsFragment.java | 12 ++--- .../deck/ui/card/details/CardDetailsFragment.java | 2 +- .../deck/ui/pickstack/PickStackFragment.java | 19 +++---- .../ui/preparecreate/PrepareCreateActivity.java | 2 +- .../deck/ui/sharetarget/ShareTargetActivity.java | 4 +- .../nextcloud/deck/ui/stack/StackFragment.java | 2 +- .../ui/upcomingcards/UpcomingCardsActivity.java | 6 +-- .../deck/ui/widget/upcoming/UpcomingWidget.java | 6 +-- .../it/niedermann/nextcloud/deck/TestUtil.java | 6 +-- .../nextcloud/deck/api/ResponseCallbackTest.java | 22 ++++---- .../deck/persistence/sync/SyncManagerTest.java | 62 +++++++++++----------- .../sync/adapters/db/DataBaseAdapterTest.java | 27 ++++------ .../sync/adapters/db/DeckDatabaseTestUtil.java | 28 ---------- .../sync/adapters/db/dao/AccountDaoTest.java | 17 +++--- .../sync/adapters/db/dao/BoardDaoTest.java | 29 +++++----- 42 files changed, 212 insertions(+), 247 deletions(-) diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/api/RequestHelper.java b/app/src/main/java/it/niedermann/nextcloud/deck/api/RequestHelper.java index f17810370..e1c2b738f 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/api/RequestHelper.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/api/RequestHelper.java @@ -49,7 +49,7 @@ public class RequestHelper { @NonNull private final ResponseCallback callback; @NonNull - private final Consumer exceptionConsumer = new Consumer() { + private final Consumer exceptionConsumer = new Consumer<>() { @Override public void accept(final Throwable throwable) { callback.onError(throwable); diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/api/ResponseCallback.java b/app/src/main/java/it/niedermann/nextcloud/deck/api/ResponseCallback.java index 4b23bda60..113d58332 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/api/ResponseCallback.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/api/ResponseCallback.java @@ -49,7 +49,7 @@ public abstract class ResponseCallback implements IResponseCallback { private boolean isListOfRemoteEntity(T response) { if (response instanceof List) { - List collection = (List) response; + final var collection = (List) response; return collection.size() > 0 && collection.get(0) instanceof AbstractRemoteEntity; } return false; @@ -64,7 +64,7 @@ public abstract class ResponseCallback implements IResponseCallback { * Forwards responses and errors to the given {@param callback} */ public static ResponseCallback from(@NonNull Account account, IResponseCallback callback) { - return new ResponseCallback(account) { + return new ResponseCallback<>(account) { @Override public void onResponse(T response) { callback.onResponse(response); diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/model/ocs/Version.java b/app/src/main/java/it/niedermann/nextcloud/deck/model/ocs/Version.java index e3ded9305..4f4698a5a 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/model/ocs/Version.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/model/ocs/Version.java @@ -19,9 +19,9 @@ public class Version implements Comparable { private static final Version VERSION_1_3_0 = new Version("1.3.0", 1, 3, 0); private String originalVersion = "?"; - private int major = 0; - private int minor = 0; - private int patch = 0; + private int major; + private int minor; + private int patch; public Version(String originalVersion, int major, int minor, int patch) { this(major, minor, patch); diff --git a/app/src/main/java/it/niedermann/nextcloud/deck/persistence/sync/SyncManager.java b/app/src/main/java/it/niedermann/nextcloud/deck/persistence/sync/SyncManager.java index d2fc568df..c0002c43f 100644 --- a/app/src/main/java/it/niedermann/nextcloud/deck/persistence/sync/SyncManager.java +++ b/app/src/main/java/it/niedermann/nextcloud/deck/persistence/sync/SyncManager.java @@ -141,7 +141,7 @@ public class SyncManager { CountDownLatch latch = new CountDownLatch(accounts.size()); try { for (Account account : accounts) { - new SyncManager(dataBaseAdapter.getContext(), account.getName()).synchronize(new ResponseCallback(account) { + new SyncManager(dataBaseAdapter.getContext(), account.getName()).synchronize(new ResponseCallback<>(account) { @Override public void onResponse(Boolean response) { success.set(success.get() && Boolean.TRUE.equals(response)); @@ -206,7 +206,7 @@ public class SyncManager { throw new IllegalArgumentException(Account.class.getSimpleName() + " object in given " + ResponseCallback.class.getSimpleName() + " must contain a valid id, but given id was null."); } executor.submit(() -> { - refreshCapabilities(new ResponseCallback(responseCallback.getAccount()) { + refreshCapabilities(new ResponseCallback<>(responseCallback.getAccount()) { @Override public void onResponse(Capabilities response) { if (response != null && !response.isMaintenanceEnabled()) { @@ -216,10 +216,10 @@ public class SyncManager { final SyncHelper syncHelper = syncHelperFactory.create(serverAdapter, dataBaseAdapter, lastSyncDate); - ResponseCallback callback = new ResponseCallback(callbackAccount) { + ResponseCallback callback = new ResponseCallback<>(callbackAccount) { @Override public void onResponse(Boolean response) { - syncHelper.setResponseCallback(new ResponseCallback(account) { + syncHelper.setResponseCallback(new ResponseCallback<>(account) { @Override public void onResponse(Boolean response) { LastSyncUtil.setLastSyncDate(accountId, Instant.now()); @@ -388,7 +388,7 @@ public class SyncManager { executor.submit(() -> { for (Account account : accounts) { syncHelperFactory.create(serverAdapter, dataBaseAdapter, null) - .setResponseCallback(new ResponseCallback(account) { + .setResponseCallback(new ResponseCallback<>(account) { @Override public void onResponse(Boolean response) { liveData.postValue(dataBaseAdapter.readAccountsForHostWithReadAccessToBoardDirectly(host, boardRemoteId)); @@ -406,7 +406,7 @@ public class SyncManager { return executor.submit(() -> { try { Account accountForEtag = dataBaseAdapter.getAccountByIdDirectly(callback.getAccount().getId()); - serverAdapter.getCapabilities(accountForEtag.getEtag(), new ResponseCallback>(callback.getAccount()) { + serverAdapter.getCapabilities(accountForEtag.getEtag(), new ResponseCallback<>(callback.getAccount()) { @Override public void onResponse(ParsedResponse response) { Account acc = dataBaseAdapter.getAccountByIdDirectly(account.getId()); @@ -657,7 +657,7 @@ public class SyncManager { serverAdapterToUse = new ServerAdapter(appContext, targetAccount.getName()); } syncHelperFactory.create(serverAdapterToUse, dataBaseAdapter, null) - .setResponseCallback(new ResponseCallback(targetAccount) { + .setResponseCallback(new ResponseCallback<>(targetAccount) { @Override public void onResponse(Boolean response) { callback.onResponse(dataBaseAdapter.getFullBoardByLocalIdDirectly(targetAccountId, newBoardId)); @@ -681,7 +681,7 @@ public class SyncManager { if (serverAdapter.hasInternetConnection()) { if (card.getId() != null) { syncHelperFactory.create(serverAdapter, dataBaseAdapter, null) - .setResponseCallback(new ResponseCallback(dataBaseAdapter.getAccountByIdDirectly(card.getAccountId())) { + .setResponseCallback(new ResponseCallback<>(dataBaseAdapter.getAccountByIdDirectly(card.getAccountId())) { @Override public void onResponse(Boolean response) { // do nothing @@ -701,7 +701,7 @@ public class SyncManager { Account account = dataBaseAdapter.getAccountByIdDirectly(accountId); Card card = dataBaseAdapter.getCardByLocalIdDirectly(accountId, cardId); OcsComment commentEntity = OcsComment.of(comment); - new DataPropagationHelper(serverAdapter, dataBaseAdapter, executor).createEntity(new DeckCommentsDataProvider(null, card), commentEntity, new ResponseCallback(account) { + new DataPropagationHelper(serverAdapter, dataBaseAdapter, executor).createEntity(new DeckCommentsDataProvider(null, card), commentEntity, new ResponseCallback<>(account) { @Override public void onResponse(OcsComment response) { // nothing so far @@ -718,7 +718,7 @@ public class SyncManager { DeckComment entity = dataBaseAdapter.getCommentByLocalIdDirectly(accountId, localCommentId); entity.setMessage(comment); OcsComment commentEntity = OcsComment.of(entity); - new DataPropagationHelper(serverAdapter, dataBaseAdapter, executor).updateEntity(new DeckCommentsDataProvider(null, card), commentEntity, new ResponseCallback(account) { + new DataPropagationHelper(serverAdapter, dataBaseAdapter, executor).updateEntity(new DeckCommentsDataProvider(null, card), commentEntity, new ResponseCallback<>(account) { @Override public void onResponse(OcsComment response) { // nothing so far @@ -814,7 +814,7 @@ public class SyncManager { Account account = dataBaseAdapter.getAccountByIdDirectly(entity.getAccountId()); FullBoard board = dataBaseAdapter.getFullBoardByLocalIdDirectly(entity.getAccountId(), entity.getBoardId()); new DataPropagationHelper(serverAdapter, dataBaseAdapter, executor).deleteEntity( - new AccessControlDataProvider(null, board, Collections.singletonList(entity)), entity, new ResponseCallback(account) { + new AccessControlDataProvider(null, board, Collections.singletonList(entity)), entity, new ResponseCallback<>(account) { @Override public void onResponse(Void response) { // revoked own board-access? @@ -1020,7 +1020,7 @@ public class SyncManager { if (serverAdapter.hasInternetConnection()) { syncHelperFactory.create(serverAdapter, dataBaseAdapter, null) - .setResponseCallback(new ResponseCallback(account) { + .setResponseCallback(new ResponseCallback<>(account) { @Override public void onResponse(Boolean response) { callback.onResponse(card); @@ -1101,7 +1101,7 @@ public class SyncManager { continue; } card.getCard().setArchived(true); - updateCardForArchive(stack, board, card, new ResponseCallback(account) { + updateCardForArchive(stack, board, card, new ResponseCallback<>(account) { @Override public void onResponse(FullCard response) { latch.countDown(); @@ -1185,7 +1185,7 @@ public class SyncManager { if (serverAdapter.hasInternetConnection()) { Account account = dataBaseAdapter.getAccountByIdDirectly(card.getAccountId()); syncHelperFactory.create(serverAdapter, dataBaseAdapter, null) - .setResponseCallback(new ResponseCallback(account) { + .setResponseCallback(new ResponseCallback<>(account) { @Override public void onResponse(Boolean response) { callback.onResponse(dataBaseAdapter.getFullCardByLocalIdDirectly(card.getAccountId(), card.getLocalId())); @@ -1263,7 +1263,7 @@ public class SyncManager { if (originAccountId != targetAccountId) { serverToUse = new ServerAdapter(appContext, targetAccount.getName()); } - new DataPropagationHelper(serverToUse, dataBaseAdapter, executor).createEntity(new CardPropagationDataProvider(null, targetBoard.getBoard(), targetFullStack), fullCardForServerPropagation, new ResponseCallback(targetAccount) { + new DataPropagationHelper(serverToUse, dataBaseAdapter, executor).createEntity(new CardPropagationDataProvider(null, targetBoard.getBoard(), targetFullStack), fullCardForServerPropagation, new ResponseCallback<>(targetAccount) { @Override public void onResponse(FullCard response) { originalInnerCard.setId(response.getId()); @@ -1380,7 +1380,7 @@ public class SyncManager { Account account = dataBaseAdapter.getAccountByIdDirectly(accountId); Board board = dataBaseAdapter.getBoardByLocalCardIdDirectly(localCardId); label.setAccountId(accountId); - new DataPropagationHelper(serverAdapterToUse, dataBaseAdapter, executor).createEntity(new LabelDataProvider(null, board, null), label, new ResponseCallback