diff options
author | stefan-niedermann <info@niedermann.it> | 2020-01-07 22:31:04 +0300 |
---|---|---|
committer | stefan-niedermann <info@niedermann.it> | 2020-01-07 22:31:04 +0300 |
commit | b295bc90503cc71cdacdaffb36ed8cb89b46fe6c (patch) | |
tree | e6525ff09c3cebf3c08baa01ca4280948deca203 | |
parent | 14313caa125f21ba42bc2d0ef43c9c7333d9f9af (diff) |
Fix #668 Empty two-digit numbered-list item crashes applicationv2.4.3
and version bump to 2.4.3
Requires at least Files app¹ version 3.9.0
¹ https://github.com/nextcloud/android
5 files changed, 15 insertions, 3 deletions
diff --git a/app/build.gradle b/app/build.gradle index 341ce193..2ff28846 100644 --- a/app/build.gradle +++ b/app/build.gradle @@ -13,8 +13,8 @@ android { applicationId "it.niedermann.owncloud.notes" minSdkVersion 14 targetSdkVersion 28 - versionCode 65 - versionName "2.4.2" + versionCode 66 + versionName "2.4.3" // vectorDrawables.useSupportLibrary = true } buildTypes { diff --git a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java index 892ca681..06dae310 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/NotePreviewFragment.java @@ -118,7 +118,14 @@ public class NotePreviewFragment extends BaseNoteFragment { ) .build()); setActiveTextView(noteContent); - noteContent.setText(markdownProcessor.parse(note.getContent())); + try { + noteContent.setText(markdownProcessor.parse(note.getContent())); + } catch (StringIndexOutOfBoundsException e) { + // Workaround for RxMarkdown: https://github.com/stefan-niedermann/nextcloud-notes/issues/668 + noteContent.setText(note.getContent()); + Toast.makeText(noteContent.getContext(), R.string.could_not_load_preview_two_digit_numbered_list, Toast.LENGTH_LONG).show(); + e.printStackTrace(); + } changedText = note.getContent(); noteContent.setMovementMethod(LinkMovementMethod.getInstance()); diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index db8419c4..1782b39d 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -136,6 +136,7 @@ <string name="account_already_imported">Account has already been imported</string> <string name="no_notes_yet">No notes yet</string> <string name="no_notes_yet_description">Press + button to create a new note</string> + <string name="could_not_load_preview_two_digit_numbered_list">Could not load preview. Please check whether there is a two-digit numbered list item without content.</string> <!-- Array: note modes --> <string-array name="noteMode_entries"> diff --git a/fastlane/metadata/android/en-US/changelogs/66.txt b/fastlane/metadata/android/en-US/changelogs/66.txt index e69de29b..148f0c50 100644 --- a/fastlane/metadata/android/en-US/changelogs/66.txt +++ b/fastlane/metadata/android/en-US/changelogs/66.txt @@ -0,0 +1,4 @@ +- #668 Empty two-digit numbered-list item crashes application + +Requires at least Files app¹ version 3.9.0 +¹ https://github.com/nextcloud/android
\ No newline at end of file diff --git a/fastlane/metadata/android/en-US/changelogs/67.txt b/fastlane/metadata/android/en-US/changelogs/67.txt new file mode 100644 index 00000000..e69de29b --- /dev/null +++ b/fastlane/metadata/android/en-US/changelogs/67.txt |