Condensed code in PreferencesFragment used to set the theme pref

summary.

1 files changed, 2 insertions, 10 deletions

diff --git a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/PreferencesFragment.java b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/PreferencesFragment.java
index efaf79c0..6a3bb05b 100644
--- a/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/PreferencesFragment.java
+++ b/app/src/main/java/it/niedermann/owncloud/notes/android/fragment/PreferencesFragment.java
@@ -32,9 +32,9 @@ public class PreferencesFragment extends PreferenceFragment {
 
         final SwitchPreference themePref = (SwitchPreference) findPreference(getString(R.string.pref_key_theme));
         SharedPreferences sp = PreferenceManager.getDefaultSharedPreferences(getActivity().getApplicationContext());
-        Boolean darkTheme = sp.getBoolean(getString(R.string.pref_key_theme), false);
 
-        setThemePreferenceSummary(themePref, darkTheme);
+        themePref.setSummary(sp.getBoolean(getString(R.string.pref_key_theme), false) ?
+                            getString(R.string.pref_value_theme_dark) : getString(R.string.pref_value_theme_light));
         themePref.setOnPreferenceChangeListener(new Preference.OnPreferenceChangeListener() {
             @Override
             public boolean onPreferenceChange(Preference preference, Object newValue) {
@@ -47,12 +47,4 @@ public class PreferencesFragment extends PreferenceFragment {
             }
         });
     }
-
-    private void setThemePreferenceSummary(SwitchPreference themePref, Boolean darkTheme) {
-        if (darkTheme) {
-            themePref.setSummary(getString(R.string.pref_value_theme_dark));
-        } else {
-            themePref.setSummary(getString(R.string.pref_value_theme_light));
-        }
-    }
 }