From fcebf67c03e4357b702c316b6376d711332db975 Mon Sep 17 00:00:00 2001 From: Stefan Niedermann Date: Thu, 11 Aug 2022 09:47:18 +0200 Subject: =?UTF-8?q?=F0=9F=90=9E=20Fix=20#1541=20Favorite=20star=20in=20men?= =?UTF-8?q?u=20not=20clickable?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Stefan Niedermann --- .../main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java | 3 ++- fastlane/metadata/android/en-US/changelogs/3005001.txt | 1 + 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java b/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java index 06953006..2683d8f0 100644 --- a/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java +++ b/app/src/main/java/it/niedermann/owncloud/notes/edit/BaseNoteFragment.java @@ -201,7 +201,7 @@ public abstract class BaseNoteFragment extends BrandedFragment implements Catego } private void prepareFavoriteOption(MenuItem item) { - item.setIcon(TRUE.equals(note.getFavorite()) ? R.drawable.ic_star_white_24dp : R.drawable.ic_star_border_white_24dp); + item.setIcon(note.getFavorite() ? R.drawable.ic_star_white_24dp : R.drawable.ic_star_border_white_24dp); item.setChecked(note.getFavorite()); tintMenuIcon(item, colorAccent); } @@ -227,6 +227,7 @@ public abstract class BaseNoteFragment extends BrandedFragment implements Catego listener.close(); return true; } else if (itemId == R.id.menu_favorite) { + note.setFavorite(!note.getFavorite()); repo.toggleFavoriteAndSync(localAccount, note.getId()); listener.onNoteUpdated(note); prepareFavoriteOption(item); diff --git a/fastlane/metadata/android/en-US/changelogs/3005001.txt b/fastlane/metadata/android/en-US/changelogs/3005001.txt index 44629770..3aac5ff6 100644 --- a/fastlane/metadata/android/en-US/changelogs/3005001.txt +++ b/fastlane/metadata/android/en-US/changelogs/3005001.txt @@ -1,4 +1,5 @@ - 📱️ Add option to not keep screen on (#1531) +- 🐞 Favorite star in menu not clickable (#1541) - ⚙️ Add monochrome icon (#1544) - by @salixor - ⚙️ Use the new Android 12 SplashScreen API (#1546) - by @salixor - 🌎 Updated translations \ No newline at end of file -- cgit v1.2.3