diff options
| author | Lukas Matena <lukasmatena@seznam.cz> | 2019-05-22 17:43:14 +0300 |
|---|---|---|
| committer | Lukas Matena <lukasmatena@seznam.cz> | 2019-05-22 17:48:20 +0300 |
| commit | 07282eb24d027817b4279f59ebbf0d80bac5f950 (patch) | |
| tree | 1096f7eb0a97912139115b9d9c8acbcfdb121bb7 /xs | |
| parent | 82740835fbe64af4bba11f0122706f0009a670be (diff) | |
Fixed unit tests when run with range checks on std::vector
There was a bug in unit tests that led to generating the wipe tower with non-normalized preset.
This caused out-of-bounds access into max_layer_height vector in fill_wipe_tower_partitions.
The problem surfaced in https://github.com/prusa3d/PrusaSlicer/issues/2288.
I quickly patched additional normalization of the preset to prevent this from happening.
Also, an assert in the same function turned out to trip on one of the tests.
This one was commented out for now and will (hopefully) be looked into later.
Function Print::apply_config was renamed to apply_config_perl_tests_only so everyone
sees its current purpose and does not mistake it for the more important Print::apply.
Diffstat (limited to 'xs')
| -rw-r--r-- | xs/xsp/Print.xsp | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/xs/xsp/Print.xsp b/xs/xsp/Print.xsp index f4c04577d..c35f967f8 100644 --- a/xs/xsp/Print.xsp +++ b/xs/xsp/Print.xsp @@ -142,8 +142,8 @@ _constant() %}; void add_model_object(ModelObject* model_object, int idx = -1); - bool apply_config(DynamicPrintConfig* config) - %code%{ RETVAL = THIS->apply_config(*config); %}; + bool apply_config_perl_tests_only(DynamicPrintConfig* config) + %code%{ RETVAL = THIS->apply_config_perl_tests_only(*config); %}; bool has_infinite_skirt(); std::vector<unsigned int> extruders() const; int validate() %code%{ |