From fe68143ff1b98f9001e5f442a481ee5a041cfb28 Mon Sep 17 00:00:00 2001 From: Luca Antiga Date: Thu, 13 Jul 2017 22:37:27 +0200 Subject: Wrap unbiased flag in var, std, varall, stdall --- lib/TH/generic/THTensorMath.c | 16 ++++++++-------- lib/TH/generic/THTensorMath.h | 8 ++++---- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/lib/TH/generic/THTensorMath.c b/lib/TH/generic/THTensorMath.c index e85d607..ac099cf 100644 --- a/lib/TH/generic/THTensorMath.c +++ b/lib/TH/generic/THTensorMath.c @@ -2925,7 +2925,7 @@ void THTensor_(mean)(THTensor *r_, THTensor *t, int dimension, int keepdim) THTensor_(div)(r_, r_, t->size[dimension]); } -void THTensor_(std)(THTensor *r_, THTensor *t, int dimension, int flag, int keepdim) +void THTensor_(std)(THTensor *r_, THTensor *t, int dimension, int biased, int keepdim) { THLongStorage *dim; @@ -2948,7 +2948,7 @@ void THTensor_(std)(THTensor *r_, THTensor *t, int dimension, int flag, int keep sum2 += z*z; } - if(flag) + if(biased) { sum /= t_size; sum2 /= t_size; @@ -2970,7 +2970,7 @@ void THTensor_(std)(THTensor *r_, THTensor *t, int dimension, int flag, int keep } } -void THTensor_(var)(THTensor *r_, THTensor *t, int dimension, int flag, int keepdim) +void THTensor_(var)(THTensor *r_, THTensor *t, int dimension, int biased, int keepdim) { THLongStorage *dim; @@ -2993,7 +2993,7 @@ void THTensor_(var)(THTensor *r_, THTensor *t, int dimension, int flag, int keep sum2 += z*z; } - if(flag) + if(biased) { sum /= t_size; sum2 /= t_size; @@ -3133,18 +3133,18 @@ accreal THTensor_(meanall)(THTensor *tensor) return THTensor_(sumall)(tensor)/THTensor_(nElement)(tensor); } -accreal THTensor_(varall)(THTensor *tensor) +accreal THTensor_(varall)(THTensor *tensor, int biased) { accreal mean = THTensor_(meanall)(tensor); accreal sum = 0; TH_TENSOR_APPLY(real, tensor, sum += (*tensor_data - mean)*(*tensor_data - mean);); - sum /= (THTensor_(nElement)(tensor)-1); + sum /= THTensor_(nElement)(tensor) - (biased ? 0 : 1); return sum; } -accreal THTensor_(stdall)(THTensor *tensor) +accreal THTensor_(stdall)(THTensor *tensor, int biased) { - return sqrt(THTensor_(varall)(tensor)); + return sqrt(THTensor_(varall)(tensor, biased)); } void THTensor_(linspace)(THTensor *r_, real a, real b, long n) diff --git a/lib/TH/generic/THTensorMath.h b/lib/TH/generic/THTensorMath.h index 17e54cc..d0963b1 100644 --- a/lib/TH/generic/THTensorMath.h +++ b/lib/TH/generic/THTensorMath.h @@ -169,8 +169,8 @@ TH_API void THTensor_(frac)(THTensor *r_, THTensor *t); TH_API void THTensor_(lerp)(THTensor *r_, THTensor *a, THTensor *b, real weight); TH_API void THTensor_(mean)(THTensor *r_, THTensor *t, int dimension, int keepdim); -TH_API void THTensor_(std)(THTensor *r_, THTensor *t, int dimension, int flag, int keepdim); -TH_API void THTensor_(var)(THTensor *r_, THTensor *t, int dimension, int flag, int keepdim); +TH_API void THTensor_(std)(THTensor *r_, THTensor *t, int dimension, int biased, int keepdim); +TH_API void THTensor_(var)(THTensor *r_, THTensor *t, int dimension, int biased, int keepdim); TH_API void THTensor_(norm)(THTensor *r_, THTensor *t, real value, int dimension, int keepdim); TH_API void THTensor_(renorm)(THTensor *r_, THTensor *t, real value, int dimension, real maxnorm); TH_API accreal THTensor_(dist)(THTensor *a, THTensor *b, real value); @@ -178,8 +178,8 @@ TH_API void THTensor_(histc)(THTensor *hist, THTensor *tensor, long nbins, real TH_API void THTensor_(bhistc)(THTensor *hist, THTensor *tensor, long nbins, real minvalue, real maxvalue); TH_API accreal THTensor_(meanall)(THTensor *self); -TH_API accreal THTensor_(varall)(THTensor *self); -TH_API accreal THTensor_(stdall)(THTensor *self); +TH_API accreal THTensor_(varall)(THTensor *self, int biased); +TH_API accreal THTensor_(stdall)(THTensor *self, int biased); TH_API accreal THTensor_(normall)(THTensor *t, real value); TH_API void THTensor_(linspace)(THTensor *r_, real a, real b, long n); -- cgit v1.2.3