diff options
| author | Louis-Maxime Piton <louismaxime.piton@orange.com> | 2022-05-20 20:28:31 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-05-20 20:28:31 +0300 |
| commit | e2e107fc7215f36ff73cf2fbb29e35d703a82679 (patch) | |
| tree | 6d614803e535956fc3b264cc3ac5a540127b85ef | |
| parent | 8959bf3f0bbaca514967661a6b721a3f065f49a9 (diff) | |
CSS: few proposals (#36406)
* Something to try about `!important` in color-bg helper
* Better understanding border utility `.border-*-0`
* Having rounded numbers of px
| -rw-r--r-- | scss/helpers/_color-bg.scss | 6 | ||||
| -rw-r--r-- | site/assets/scss/_component-examples.scss | 10 | ||||
| -rw-r--r-- | site/content/docs/5.2/utilities/borders.md | 12 |
3 files changed, 11 insertions, 17 deletions
diff --git a/scss/helpers/_color-bg.scss b/scss/helpers/_color-bg.scss index 80ba863034..b5ce7709c1 100644 --- a/scss/helpers/_color-bg.scss +++ b/scss/helpers/_color-bg.scss @@ -1,10 +1,10 @@ -// stylelint-disable declaration-no-important, function-name-case +// stylelint-disable function-name-case // All-caps `RGBA()` function used because of this Sass bug: https://github.com/sass/node-sass/issues/2251 @each $color, $value in $theme-colors { $color-rgb: to-rgb($value); .text-bg-#{$color} { - color: color-contrast($value) !important; - background-color: RGBA($color-rgb, var(--#{$prefix}bg-opacity, 1)) !important; + color: color-contrast($value) if($enable-important-utilities, !important, null); + background-color: RGBA($color-rgb, var(--#{$prefix}bg-opacity, 1)) if($enable-important-utilities, !important, null); } } diff --git a/site/assets/scss/_component-examples.scss b/site/assets/scss/_component-examples.scss index 52b67543a8..6f32568946 100644 --- a/site/assets/scss/_component-examples.scss +++ b/site/assets/scss/_component-examples.scss @@ -257,12 +257,6 @@ } } -.bd-example-border-utils-0 { - [class^="border"] { - border: var(--#{$prefix}border-width) solid var(--#{$prefix}border-color); - } -} - .bd-example-rounded-utils { [class*="rounded"] { margin: .25rem; @@ -325,8 +319,8 @@ pre { padding: 0; - margin-top: .65rem; - margin-bottom: .65rem; + margin-top: .625rem; + margin-bottom: .625rem; white-space: pre; background-color: transparent; border: 0; diff --git a/site/content/docs/5.2/utilities/borders.md b/site/content/docs/5.2/utilities/borders.md index 0cf9a74546..64913bbc91 100644 --- a/site/content/docs/5.2/utilities/borders.md +++ b/site/content/docs/5.2/utilities/borders.md @@ -26,12 +26,12 @@ Add borders to custom elements: Or remove borders: -{{< example class="bd-example-border-utils bd-example-border-utils-0" >}} -<span class="border-0"></span> -<span class="border-top-0"></span> -<span class="border-end-0"></span> -<span class="border-bottom-0"></span> -<span class="border-start-0"></span> +{{< example class="bd-example-border-utils" >}} +<span class="border border-0"></span> +<span class="border border-top-0"></span> +<span class="border border-end-0"></span> +<span class="border border-bottom-0"></span> +<span class="border border-start-0"></span> {{< /example >}} ## Color |