diff options
| author | Patrick H. Lauke <redux@splintered.co.uk> | 2020-10-14 13:59:43 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-10-14 13:59:43 +0300 |
| commit | 836a4c0bd6b93499304f9814a946dd065cb01bef (patch) | |
| tree | ebd519738826bf7cd0031e0f6d26324cc989ea89 | |
| parent | 0205a016b1910eb861ac01ef1644d96855eafb9d (diff) | |
Remove redundant visually hidden "(current)" from pagination controls (#31892)
* Replace visually hidden span with aria-current in tests
* Remove redundant visually hidden "(current)" when `aria-current` already used
Closes #31891
| -rw-r--r-- | js/tests/visual/dropdown.html | 2 | ||||
| -rw-r--r-- | js/tests/visual/modal.html | 2 | ||||
| -rw-r--r-- | site/content/docs/5.0/components/pagination.md | 17 |
3 files changed, 6 insertions, 15 deletions
diff --git a/js/tests/visual/dropdown.html b/js/tests/visual/dropdown.html index a7ceb32e21..fcbe067ae9 100644 --- a/js/tests/visual/dropdown.html +++ b/js/tests/visual/dropdown.html @@ -19,7 +19,7 @@ <div class="collapse navbar-collapse" id="navbarResponsive"> <ul class="navbar-nav"> <li class="nav-item active"> - <a class="nav-link" href="#">Home <span class="visually-hidden">(current)</span></a> + <a class="nav-link" href="#" aria-current="page">Home</a> </li> <li class="nav-item"> <a class="nav-link" href="#">Link</a> diff --git a/js/tests/visual/modal.html b/js/tests/visual/modal.html index b72e8c4ef7..31c6a6a3b4 100644 --- a/js/tests/visual/modal.html +++ b/js/tests/visual/modal.html @@ -19,7 +19,7 @@ <a class="navbar-brand" href="#">This shouldn't jump!</a> <ul class="navbar-nav"> <li class="nav-item active"> - <a class="nav-link" href="#">Home <span class="visually-hidden">(current)</span></a> + <a class="nav-link" href="#" aria-current="page">Home</a> </li> <li class="nav-item"> <a class="nav-link" href="#">Link</a> diff --git a/site/content/docs/5.0/components/pagination.md b/site/content/docs/5.0/components/pagination.md index 076c314101..23b474589d 100644 --- a/site/content/docs/5.0/components/pagination.md +++ b/site/content/docs/5.0/components/pagination.md @@ -62,7 +62,7 @@ While the `.disabled` class uses `pointer-events: none` to _try_ to disable the </li> <li class="page-item"><a class="page-link" href="#">1</a></li> <li class="page-item active" aria-current="page"> - <a class="page-link" href="#">2 <span class="visually-hidden">(current)</span></a> + <a class="page-link" href="#">2</a> </li> <li class="page-item"><a class="page-link" href="#">3</a></li> <li class="page-item"> @@ -82,10 +82,7 @@ You can optionally swap out active or disabled anchors for `<span>`, or omit the </li> <li class="page-item"><a class="page-link" href="#">1</a></li> <li class="page-item active" aria-current="page"> - <span class="page-link"> - 2 - <span class="visually-hidden">(current)</span> - </span> + <span class="page-link">2</span> </li> <li class="page-item"><a class="page-link" href="#">3</a></li> <li class="page-item"> @@ -103,10 +100,7 @@ Fancy larger or smaller pagination? Add `.pagination-lg` or `.pagination-sm` for <nav aria-label="..."> <ul class="pagination pagination-lg"> <li class="page-item active" aria-current="page"> - <span class="page-link"> - 1 - <span class="visually-hidden">(current)</span> - </span> + <span class="page-link">1</span> </li> <li class="page-item"><a class="page-link" href="#">2</a></li> <li class="page-item"><a class="page-link" href="#">3</a></li> @@ -118,10 +112,7 @@ Fancy larger or smaller pagination? Add `.pagination-lg` or `.pagination-sm` for <nav aria-label="..."> <ul class="pagination pagination-sm"> <li class="page-item active" aria-current="page"> - <span class="page-link"> - 1 - <span class="visually-hidden">(current)</span> - </span> + <span class="page-link">1</span> </li> <li class="page-item"><a class="page-link" href="#">2</a></li> <li class="page-item"><a class="page-link" href="#">3</a></li> |