diff options
author | Louis-Maxime Piton <louismaxime.piton@orange.com> | 2022-05-24 20:39:57 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2022-05-24 20:39:57 +0300 |
commit | dea14df8ca9dffbaa77168fa7bdac853364d52c5 (patch) | |
tree | b7f6dff439a7e12d940b10aa929c3e2b2e17d3ad | |
parent | afef596f2019ba8a8d2f28153281afd2d8d39367 (diff) |
CSS: doc fixes (#36425)
* Remove unused attributes
* Use utilities rather than using new CSS
* Removed unused class
* Change StackBlitz icon `aria-label` + small inconsistency
-rw-r--r-- | site/assets/js/code-examples.js | 2 | ||||
-rw-r--r-- | site/assets/scss/_clipboard-js.scss | 7 | ||||
-rw-r--r-- | site/assets/scss/_masthead.scss | 4 | ||||
-rw-r--r-- | site/content/docs/5.2/components/alerts.md | 16 | ||||
-rw-r--r-- | site/layouts/partials/docs-navbar.html | 2 | ||||
-rw-r--r-- | site/layouts/shortcodes/example.html | 8 |
6 files changed, 14 insertions, 25 deletions
diff --git a/site/assets/js/code-examples.js b/site/assets/js/code-examples.js index 4a61fa09b7..25486c2fe7 100644 --- a/site/assets/js/code-examples.js +++ b/site/assets/js/code-examples.js @@ -22,7 +22,7 @@ '<div class="bd-code-snippet">', ' <div class="bd-clipboard">', ' <button type="button" class="btn-clipboard">', - ' <svg class="bi" width="1em" height="1em" fill="currentColor" role="img" aria-label="Copy"><use xlink:href="#clipboard"/></svg>', + ' <svg class="bi" role="img" aria-label="Copy"><use xlink:href="#clipboard"/></svg>', ' </button>', ' </div>', '</div>' diff --git a/site/assets/scss/_clipboard-js.scss b/site/assets/scss/_clipboard-js.scss index b4d8e234fc..3a876a5e63 100644 --- a/site/assets/scss/_clipboard-js.scss +++ b/site/assets/scss/_clipboard-js.scss @@ -42,10 +42,3 @@ margin-top: .75rem; margin-right: .75rem; } - -.highlight-toolbar { - .btn-clipboard { - margin-top: 0; - margin-right: 0; - } -} diff --git a/site/assets/scss/_masthead.scss b/site/assets/scss/_masthead.scss index 76d003c95e..81d4d998cb 100644 --- a/site/assets/scss/_masthead.scss +++ b/site/assets/scss/_masthead.scss @@ -90,10 +90,6 @@ } } -.masthead-followup-svg { - filter: drop-shadow(0 1px 0 rgba(0, 0, 0, .125)); -} - .masthead-notice { background-color: var(--bd-accent); box-shadow: inset 0 -1px 1px rgba(var(--bs-body-color-rgb), .15), 0 .25rem 1.5rem rgba(var(--bs-body-bg-rgb), .75); diff --git a/site/content/docs/5.2/components/alerts.md b/site/content/docs/5.2/components/alerts.md index 59f9a349f8..12cad35881 100644 --- a/site/content/docs/5.2/components/alerts.md +++ b/site/content/docs/5.2/components/alerts.md @@ -89,7 +89,7 @@ Similarly, you can use [flexbox utilities]({{< docsref "/utilities/flex" >}}) an {{< example >}} <div class="alert alert-primary d-flex align-items-center" role="alert"> - <svg xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="currentColor" class="bi bi-exclamation-triangle-fill flex-shrink-0 me-2" viewBox="0 0 16 16" role="img" aria-label="Warning:"> + <svg xmlns="http://www.w3.org/2000/svg" class="bi bi-exclamation-triangle-fill flex-shrink-0 me-2" viewBox="0 0 16 16" role="img" aria-label="Warning:"> <path d="M8.982 1.566a1.13 1.13 0 0 0-1.96 0L.165 13.233c-.457.778.091 1.767.98 1.767h13.713c.889 0 1.438-.99.98-1.767L8.982 1.566zM8 5c.535 0 .954.462.9.995l-.35 3.507a.552.552 0 0 1-1.1 0L7.1 5.995A.905.905 0 0 1 8 5zm.002 6a1 1 0 1 1 0 2 1 1 0 0 1 0-2z"/> </svg> <div> @@ -102,37 +102,37 @@ Need more than one icon for your alerts? Consider using more Bootstrap Icons and {{< example >}} <svg xmlns="http://www.w3.org/2000/svg" style="display: none;"> - <symbol id="check-circle-fill" fill="currentColor" viewBox="0 0 16 16"> + <symbol id="check-circle-fill" viewBox="0 0 16 16"> <path d="M16 8A8 8 0 1 1 0 8a8 8 0 0 1 16 0zm-3.97-3.03a.75.75 0 0 0-1.08.022L7.477 9.417 5.384 7.323a.75.75 0 0 0-1.06 1.06L6.97 11.03a.75.75 0 0 0 1.079-.02l3.992-4.99a.75.75 0 0 0-.01-1.05z"/> </symbol> - <symbol id="info-fill" fill="currentColor" viewBox="0 0 16 16"> + <symbol id="info-fill" viewBox="0 0 16 16"> <path d="M8 16A8 8 0 1 0 8 0a8 8 0 0 0 0 16zm.93-9.412-1 4.705c-.07.34.029.533.304.533.194 0 .487-.07.686-.246l-.088.416c-.287.346-.92.598-1.465.598-.703 0-1.002-.422-.808-1.319l.738-3.468c.064-.293.006-.399-.287-.47l-.451-.081.082-.381 2.29-.287zM8 5.5a1 1 0 1 1 0-2 1 1 0 0 1 0 2z"/> </symbol> - <symbol id="exclamation-triangle-fill" fill="currentColor" viewBox="0 0 16 16"> + <symbol id="exclamation-triangle-fill" viewBox="0 0 16 16"> <path d="M8.982 1.566a1.13 1.13 0 0 0-1.96 0L.165 13.233c-.457.778.091 1.767.98 1.767h13.713c.889 0 1.438-.99.98-1.767L8.982 1.566zM8 5c.535 0 .954.462.9.995l-.35 3.507a.552.552 0 0 1-1.1 0L7.1 5.995A.905.905 0 0 1 8 5zm.002 6a1 1 0 1 1 0 2 1 1 0 0 1 0-2z"/> </symbol> </svg> <div class="alert alert-primary d-flex align-items-center" role="alert"> - <svg class="bi flex-shrink-0 me-2" width="24" height="24" role="img" aria-label="Info:"><use xlink:href="#info-fill"/></svg> + <svg class="bi flex-shrink-0 me-2" role="img" aria-label="Info:"><use xlink:href="#info-fill"/></svg> <div> An example alert with an icon </div> </div> <div class="alert alert-success d-flex align-items-center" role="alert"> - <svg class="bi flex-shrink-0 me-2" width="24" height="24" role="img" aria-label="Success:"><use xlink:href="#check-circle-fill"/></svg> + <svg class="bi flex-shrink-0 me-2" role="img" aria-label="Success:"><use xlink:href="#check-circle-fill"/></svg> <div> An example success alert with an icon </div> </div> <div class="alert alert-warning d-flex align-items-center" role="alert"> - <svg class="bi flex-shrink-0 me-2" width="24" height="24" role="img" aria-label="Warning:"><use xlink:href="#exclamation-triangle-fill"/></svg> + <svg class="bi flex-shrink-0 me-2" role="img" aria-label="Warning:"><use xlink:href="#exclamation-triangle-fill"/></svg> <div> An example warning alert with an icon </div> </div> <div class="alert alert-danger d-flex align-items-center" role="alert"> - <svg class="bi flex-shrink-0 me-2" width="24" height="24" role="img" aria-label="Danger:"><use xlink:href="#exclamation-triangle-fill"/></svg> + <svg class="bi flex-shrink-0 me-2" role="img" aria-label="Danger:"><use xlink:href="#exclamation-triangle-fill"/></svg> <div> An example danger alert with an icon </div> diff --git a/site/layouts/partials/docs-navbar.html b/site/layouts/partials/docs-navbar.html index ff01ef778a..c728d0bd39 100644 --- a/site/layouts/partials/docs-navbar.html +++ b/site/layouts/partials/docs-navbar.html @@ -14,7 +14,7 @@ </a> <button class="navbar-toggler d-flex d-lg-none order-3 p-2" type="button" data-bs-toggle="offcanvas" data-bs-target="#bdNavbar" aria-controls="bdNavbar" aria-expanded="false" aria-label="Toggle navigation"> - <svg class="bi" width="24" height="24" aria-hidden="true"><use xlink:href="#three-dots"></use></svg> + <svg class="bi" aria-hidden="true"><use xlink:href="#three-dots"></use></svg> </button> <div class="offcanvas-lg offcanvas-end flex-grow-1" id="bdNavbar" aria-labelledby="bdNavbarOffcanvasLabel" data-bs-scroll="true"> diff --git a/site/layouts/shortcodes/example.html b/site/layouts/shortcodes/example.html index 9dab2f9d1a..9bfa2c906c 100644 --- a/site/layouts/shortcodes/example.html +++ b/site/layouts/shortcodes/example.html @@ -24,14 +24,14 @@ {{- if eq $show_markup true -}} {{- if eq $show_preview true -}} - <div class="d-flex align-items-center highlight-toolbar bg-light ps-3 pe-2 py-1"> + <div class="d-flex align-items-center highlight-toolbar bg-light ps-3 pe-2 py-1"> <small class="font-monospace text-muted text-uppercase">{{- $lang -}}</small> <div class="d-flex ms-auto"> <button type="button" class="btn-edit text-nowrap" title="Try it on StackBlitz"> - <svg class="bi" width="1em" height="1em" fill="currentColor" role="img" aria-label="Copy"><use xlink:href="#lightning-charge-fill"/></svg> + <svg class="bi" role="img" aria-label="Try it"><use xlink:href="#lightning-charge-fill"/></svg> </button> - <button type="button" class="btn-clipboard" title="Copy to clipboard"> - <svg class="bi" width="1em" height="1em" fill="currentColor" role="img" aria-label="Copy"><use xlink:href="#clipboard"/></svg> + <button type="button" class="btn-clipboard mt-0 me-0" title="Copy to clipboard"> + <svg class="bi" role="img" aria-label="Copy"><use xlink:href="#clipboard"/></svg> </button> </div> </div> |