diff options
| author | GeoSot <geo.sotis@gmail.com> | 2021-05-11 09:04:42 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-11 09:04:42 +0300 |
| commit | 03842b5f259d6007db02c465e6c55929e551e9cd (patch) | |
| tree | b5ec0345127f40dd0918ef6828c3057ca57a4c3a /js/src/scrollspy.js | |
| parent | 052def456845c2147e4e6c99d17bba12fcbee34c (diff) | |
Refactor: move disposing properties into the base class (#33740)
Moves more functionality to `base-component`, transferring the responsibility of disposal to parent class.
Each component, dusting disposal, sets its protected properties to `null`. So the same can be done in one place for all children components .
Diffstat (limited to 'js/src/scrollspy.js')
| -rw-r--r-- | js/src/scrollspy.js | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/js/src/scrollspy.js b/js/src/scrollspy.js index 0f59696602..7c59dabcff 100644 --- a/js/src/scrollspy.js +++ b/js/src/scrollspy.js @@ -137,16 +137,8 @@ class ScrollSpy extends BaseComponent { } dispose() { - super.dispose() EventHandler.off(this._scrollElement, EVENT_KEY) - - this._scrollElement = null - this._config = null - this._selector = null - this._offsets = null - this._targets = null - this._activeTarget = null - this._scrollHeight = null + super.dispose() } // Private |