diff options
| author | Ben Lertlumprasertkul <benlertlumprasertkul@gmail.com> | 2021-05-11 08:45:57 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-05-11 08:45:57 +0300 |
| commit | 052def456845c2147e4e6c99d17bba12fcbee34c (patch) | |
| tree | 9f23d9f09941c43fd519bde2498da808a8764635 /js/tests/unit/alert.spec.js | |
| parent | 9c3ab6557ec89ae11cc27da1b4680b3e69381edf (diff) | |
Remove potential false positive assertions (#33288)
* Remove potential false positive assertions
querySelector() returns null but
expect(document.querySelector('...')).toBeDefined()
tests that the value is not undefined
* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests
* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call
* convert more cases to not.toBeNull assertions
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Diffstat (limited to 'js/tests/unit/alert.spec.js')
| -rw-r--r-- | js/tests/unit/alert.spec.js | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/js/tests/unit/alert.spec.js b/js/tests/unit/alert.spec.js index 194da420e9..29b99d7921 100644 --- a/js/tests/unit/alert.spec.js +++ b/js/tests/unit/alert.spec.js @@ -134,7 +134,7 @@ describe('Alert', () => { const alertEl = document.querySelector('.alert') const alert = new Alert(alertEl) - expect(Alert.getInstance(alertEl)).toBeDefined() + expect(Alert.getInstance(alertEl)).not.toBeNull() alert.dispose() @@ -169,7 +169,7 @@ describe('Alert', () => { jQueryMock.fn.alert.call(jQueryMock, 'close') - expect(Alert.getInstance(alertEl)).toBeDefined() + expect(Alert.getInstance(alertEl)).not.toBeNull() expect(fixtureEl.querySelector('.alert')).toBeNull() }) @@ -183,7 +183,7 @@ describe('Alert', () => { jQueryMock.fn.alert.call(jQueryMock) - expect(Alert.getInstance(alertEl)).toBeDefined() + expect(Alert.getInstance(alertEl)).not.toBeNull() expect(fixtureEl.querySelector('.alert')).not.toBeNull() }) }) |