diff options
| author | Patrick H. Lauke <redux@splintered.co.uk> | 2015-06-02 11:41:40 +0300 |
|---|---|---|
| committer | Patrick H. Lauke <redux@splintered.co.uk> | 2015-06-02 13:03:21 +0300 |
| commit | 5fd7bc1554d492bdd5794d35fce515fe951439a6 (patch) | |
| tree | 61ac7cd8243c6d6c4c6e8de4b373132b01419df7 /js/tests/visual/scrollspy.html | |
| parent | 3b59b97c626bf2accef8217339b04712666c36d9 (diff) | |
generalize dropdowns / drop role="menu"
as role="menu" is a very specific (and strict) ARIA pattern for
desktop-like application menus, and our dropdowns are often used
as pure navigation dropdowns, this change abandons ARIA menus for
a more open-ended and light-weight approach
(see http://heydonworks.com/practical_aria_examples/#submenus and
http://www.w3.org/WAI/tutorials/menus/flyout/#improve-screen-reader-support-using-wai-aria)
note that in dropdown.js, switched to now target ``.dropdown-menu``
instead of ``role["menu"]`` - this also prevents bootstrap scripts
from "bleeding" into non-bootstrap components on the same page.
also removed the ``role=["listbox"]`` part, which appears to be
vestigial/unused (only place in bootstrap that uses that
role are carousels, and their key handling is done separately)
Diffstat (limited to 'js/tests/visual/scrollspy.html')
| -rw-r--r-- | js/tests/visual/scrollspy.html | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/js/tests/visual/scrollspy.html b/js/tests/visual/scrollspy.html index 5952b7e593..580faeccfd 100644 --- a/js/tests/visual/scrollspy.html +++ b/js/tests/visual/scrollspy.html @@ -38,12 +38,12 @@ <li class=""><a href="#fat">@fat</a></li> <li class=""><a href="#mdo">@mdo</a></li> <li class="dropdown"> - <a href="#" class="dropdown-toggle" data-toggle="dropdown">Dropdown <b class="caret"></b></a> - <ul class="dropdown-menu" role="menu"> - <li class=""><a href="#one" tabindex="-1">one</a></li> - <li><a href="#two" tabindex="-1">two</a></li> - <li class="divider"></li> - <li><a href="#three" tabindex="-1">three</a></li> + <a href="#" class="dropdown-toggle" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">Dropdown <b class="caret"></b></a> + <ul class="dropdown-menu"> + <li class=""><a href="#one">one</a></li> + <li><a href="#two">two</a></li> + <li role="separator" class="divider"></li> + <li><a href="#three">three</a></li> </ul> </li> </ul> |