diff options
| author | XhmikosR <xhmikosr@gmail.com> | 2021-12-10 08:51:57 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2021-12-10 08:51:57 +0300 |
| commit | 63d38b19740eac25b8603dc9a9ae11e1df4667f7 (patch) | |
| tree | 83c574d9d04fbda551672fcf7a303ee0a9e63791 /js | |
| parent | 871c8bdd3fe7218c10aa18dacf0b5c612cfff82c (diff) | |
Tab: minor refactoring (#35511)
* remove unneeded parentheses
* move variable
Diffstat (limited to 'js')
| -rw-r--r-- | js/src/tab.js | 17 |
1 files changed, 5 insertions, 12 deletions
diff --git a/js/src/tab.js b/js/src/tab.js index 4a018ca77d..f9969fb7a4 100644 --- a/js/src/tab.js +++ b/js/src/tab.js @@ -5,12 +5,7 @@ * -------------------------------------------------------------------------- */ -import { - defineJQueryPlugin, - getElementFromSelector, - isDisabled, - reflow -} from './util/index' +import { defineJQueryPlugin, getElementFromSelector, isDisabled, reflow } from './util/index' import EventHandler from './dom/event-handler' import SelectorEngine from './dom/selector-engine' import BaseComponent from './base-component' @@ -55,15 +50,15 @@ class Tab extends BaseComponent { // Public show() { - if ((this._element.parentNode && + if (this._element.parentNode && this._element.parentNode.nodeType === Node.ELEMENT_NODE && - this._element.classList.contains(CLASS_NAME_ACTIVE))) { + this._element.classList.contains(CLASS_NAME_ACTIVE)) { return } - let previous const target = getElementFromSelector(this._element) const listElement = this._element.closest(SELECTOR_NAV_LIST_GROUP) + let previous if (listElement) { const itemSelector = listElement.nodeName === 'UL' || listElement.nodeName === 'OL' ? SELECTOR_ACTIVE_UL : SELECTOR_ACTIVE @@ -75,9 +70,7 @@ class Tab extends BaseComponent { EventHandler.trigger(previous, EVENT_HIDE, { relatedTarget: this._element }) : null - const showEvent = EventHandler.trigger(this._element, EVENT_SHOW, { - relatedTarget: previous - }) + const showEvent = EventHandler.trigger(this._element, EVENT_SHOW, { relatedTarget: previous }) if (showEvent.defaultPrevented || (hideEvent !== null && hideEvent.defaultPrevented)) { return |