diff options
author | Jon Wolski <jon.wolski@groups360.com> | 2017-08-17 22:25:38 +0300 |
---|---|---|
committer | Jon Wolski <jon.wolski@groups360.com> | 2017-08-18 17:35:00 +0300 |
commit | f07d870381885f1901f7de78457761a5c13d64b3 (patch) | |
tree | 326c4720988508bab4904c4977e69cf240047c7e /scss/_badge.scss | |
parent | 74d96392d2370c5e0f54380ddb5c7a09d6c13ac7 (diff) |
Remove `color` property from `badge` class
I suggest removing `color: #FFF` from the `badge` class, because it is
provided by the `badge-<modifier>` classes along with a
background-color, whereas there is no corresponding background-color
provided on the `badge` class itself.
Background
----------
According to the documentation:
> [badge] Requires one of the contextual, color modifier classes for `color` and
> `background-color`.
That is, color and background color should be provided by a modifier
class, rather than the badge class itself.
e.g. `<span class='badge badge-primary'>4</span>`
In general, providing a `color` property without also providing a
`background-color` should be avoided. [W3 QA tips]
In this context, this is a problem only if someone creates a `badge`
without providing a modifier. Such an omition may be difficult to trouble-shoot,
because this will most likely yield white text on a white background.
[W3 QA tips](https://www.w3.org/QA/Tips/color)
Diffstat (limited to 'scss/_badge.scss')
-rw-r--r-- | scss/_badge.scss | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/scss/_badge.scss b/scss/_badge.scss index 8a76263444..fea10ebb19 100644 --- a/scss/_badge.scss +++ b/scss/_badge.scss @@ -9,7 +9,6 @@ font-size: $badge-font-size; font-weight: $badge-font-weight; line-height: 1; - color: $badge-color; text-align: center; white-space: nowrap; vertical-align: baseline; |