diff options
| author | GeoSot <geo.sotis@gmail.com> | 2022-04-13 04:16:18 +0300 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2022-04-13 04:16:18 +0300 |
| commit | 8aaeb3cb6b5fe4f3eb6ed5872e172404aa8397a6 (patch) | |
| tree | 3333ba06f75ac6b8fc47157a7a20eb109646ffb7 /scss | |
| parent | 33992b7d5b2176d90aee9a1933219b498a9888d4 (diff) | |
Remove tooltip and popover styling as it is handled by Popper (#34627)
* Remove not needed css form tooltip & popover as it is made by popper
Remove tooltip margin variable, as popper needs margin to be zero
* Remove popover left/top initializers as they are handled by popper
* nullify `margin` variable and add deprecation message
* Document change in migration guide
* Update _variables.scss
Co-authored-by: Mark Otto <markdotto@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Diffstat (limited to 'scss')
| -rw-r--r-- | scss/_popover.scss | 4 | ||||
| -rw-r--r-- | scss/_tooltip.scss | 3 | ||||
| -rw-r--r-- | scss/_variables.scss | 2 |
3 files changed, 2 insertions, 7 deletions
diff --git a/scss/_popover.scss b/scss/_popover.scss index 3f1d980b21..d43f4b0e46 100644 --- a/scss/_popover.scss +++ b/scss/_popover.scss @@ -23,9 +23,6 @@ --#{$prefix}popover-arrow-border: var(--#{$prefix}popover-border-color); // scss-docs-end popover-css-vars - position: absolute; - top: 0; - left: 0 #{"/* rtl:ignore */"}; z-index: var(--#{$prefix}popover-zindex); display: block; max-width: var(--#{$prefix}popover-max-width); @@ -42,7 +39,6 @@ @include box-shadow(var(--#{$prefix}popover-box-shadow)); .popover-arrow { - position: absolute; display: block; width: var(--#{$prefix}popover-arrow-width); height: var(--#{$prefix}popover-arrow-height); diff --git a/scss/_tooltip.scss b/scss/_tooltip.scss index a3343596b8..8f4718db89 100644 --- a/scss/_tooltip.scss +++ b/scss/_tooltip.scss @@ -17,10 +17,10 @@ --#{$prefix}tooltip-arrow-height: #{$tooltip-arrow-height}; // scss-docs-end tooltip-css-vars - position: absolute; z-index: var(--#{$prefix}tooltip-zindex); display: block; margin: var(--#{$prefix}tooltip-margin); + @include deprecate("`$tooltip-margin`", "v5", "v5.x", ); // Our parent element can be arbitrary since tooltips are by default inserted as a sibling of their target element. // So reset our font and text properties to avoid inheriting weird values. @include reset-text(); @@ -32,7 +32,6 @@ &.show { opacity: var(--#{$prefix}tooltip-opacity); } .tooltip-arrow { - position: absolute; display: block; width: var(--#{$prefix}tooltip-arrow-width); height: var(--#{$prefix}tooltip-arrow-height); diff --git a/scss/_variables.scss b/scss/_variables.scss index 85de06fc7a..6331246e10 100644 --- a/scss/_variables.scss +++ b/scss/_variables.scss @@ -1294,7 +1294,7 @@ $tooltip-border-radius: $border-radius !default; $tooltip-opacity: .9 !default; $tooltip-padding-y: $spacer * .25 !default; $tooltip-padding-x: $spacer * .5 !default; -$tooltip-margin: 0 !default; +$tooltip-margin: null !default; // TODO: remove this in v6 $tooltip-arrow-width: .8rem !default; $tooltip-arrow-height: .4rem !default; |