diff options
author | Patrick H. Lauke <redux@splintered.co.uk> | 2020-11-18 21:20:05 +0300 |
---|---|---|
committer | GitHub <noreply@github.com> | 2020-11-18 21:20:05 +0300 |
commit | 5ec6400bd01057ab1d95285b5744dcf942192ad6 (patch) | |
tree | 21ea0c8a8b22f0895709ad4d7c9cf8d2dd1fa725 /site/layouts | |
parent | de8dbd72d825a2e1bca1dea1ba99a4ef17032353 (diff) |
Docs: change sidebar collapse controls to actual button elements (#31098)
apart from the visual styling, there's probably no good reason why these shouldn't be `<button>` elements, semantically
the buttons still look a shade too button-like, despite using `.btn-light`. the last remnant of button styling can probably be suppressed further, *or* this makes the case for expanding the core button styles to have one that looks completely non-button and non-link like (for cases where an additional style/hint was given already, or it's clear from context that something's an actionable button or link)
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Diffstat (limited to 'site/layouts')
-rw-r--r-- | site/layouts/partials/docs-sidebar.html | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/site/layouts/partials/docs-sidebar.html b/site/layouts/partials/docs-sidebar.html index 06900cb231..94acb47863 100644 --- a/site/layouts/partials/docs-sidebar.html +++ b/site/layouts/partials/docs-sidebar.html @@ -16,9 +16,9 @@ {{- $is_active_group := eq $.Page.Params.group $group_slug }} <li class="mb-1{{ if $is_active_group }} active{{ end }}"> - <a class="d-inline-flex align-items-center rounded{{ if not $is_active_group }} collapsed{{ end }}" data-bs-toggle="collapse" href="#{{ $group_slug }}-collapse" role="button" aria-expanded="{{ $is_active_group }}"{{ if $is_active_group }} aria-current="true"{{ end }}> + <button class="btn d-inline-flex align-items-center rounded{{ if not $is_active_group }} collapsed{{ end }}" data-bs-toggle="collapse" data-bs-target="#{{ $group_slug }}-collapse" aria-expanded="{{ $is_active_group }}"{{ if $is_active_group }} aria-current="true"{{ end }}> {{ $group.title }} - </a> + </button> {{- if $group.pages }} <div class="collapse{{ if $is_active_group }} show{{ end }}" id="{{ $group_slug }}-collapse"> |