| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This fixes a backward incompatible change in v5.2.1 where `.drodown-toggle` isn't present in the markup.
|
|
(#37011)
|
|
|
|
* Fix carousel spec typo
* Change carousel test name in align with testing method
* Make the spies declarations the same everywhere
|
|
|
|
|
|
(#35765)
|
|
* Update devDependencies
* @babel/core ^7.17.0 → ^7.17.2
* @rollup/plugin-replace ^3.0.1 → ^3.1.0
* eslint ^8.8.0 → ^8.9.0
* eslint-config-xo ^0.39.0 → ^0.40.0
* hugo-bin ^0.80.1 → ^0.80.2
* karma ^6.3.15 → ^6.3.16
* rollup ^2.67.1 → ^2.67.2
* Fix new ESLint errors
|
|
* Fix typo in CSS variables documentation
* Drop remaining .navbar-light classes
|
|
As we use the `dataApiKeydownHandler` only for events that are triggered on `[data-bs-toggle="dropdown"]` or on `.dropdown-menu`, we can ensure that their `parentNode` will ALWAYS be the `.dropdown` wrapper
|
|
Reference:
https://jasmine.github.io/tutorials/async
'DEPRECATION: An asynchronous function called its 'done' callback more than once. This is a bug in the spec, beforeAll, beforeEach, afterAll, or afterEach function in question. This will be treated as an error in a future version. See<https://jasmine.github.io/tutorials/upgrading_to_Jasmine_4.0#deprecations-due-to-calling-done-multiple-times> for more information.
|
|
Previously we were adding an Array instead of a String
|
|
(#35500)
|
|
|
|
static popper with no styles attached
|
|
|
|
|
|
Use:
* toBeNull
* toEqual
* toBeTrue
* toBeFalse
* toHaveSize
* toHaveClass
|
|
* tests: minor cleanup
* tests: use the util noop function
|
|
|
|
element in case of not having the proper markup
|
|
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
|
|
|
|
Looking around on js components I found out many checks, different expressed but with same purpose.
Some of them are trying to parse string to element, others, jQuery element to js simple nodeElement etc
With this Pr, I am trying to give a standard way to parse an element
So this pr:
* Creates `getElement` helper that tries to parse an argument to element or null
* Changes `isElement` to make explicit checks and return Boolean
* fixes tests deficiencies
|
|
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
|
|
(#33920)
* test: add test if user clicks on input not contained within dropdown-menu
* fix: click on inputs that are not contained within dropdown-menu prevent dropdown from closing
|
|
* Remove potential false positive assertions
querySelector() returns null but
expect(document.querySelector('...')).toBeDefined()
tests that the value is not undefined
* Migrated assertions from .toBeDefined() to .not.toBeNull() for .getInstance() calls in tests
* Migrate offcanvas assertions from .toBeDefined() to .not.toBeNull() for .getInstance() call
* convert more cases to not.toBeNull assertions
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
|
|
|
|
|
|
|
|
* Update `aria-expanded` attribute in `hide` method
* Remove empty mouseover listeners added for iOS
|
|
|
|
* remove stopPropagation from button click event
* test for delegated click events
* ensure button children can open menu
* test to ensure clicking button opens the menu
* check current element and parents
* allow dropdown form click events to bubble
|
|
|
|
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <otto@github.com>
|
|
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
|
|
* Fix event handler removal in carousel dispose
* Fix event handler removal in dropdown dispose
* Test event handlers in scrollspy dispose
* Test event handlers in toast dispose
* Test event handlers in tooltip dispose
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Rohit Sharma <rohit2sharma95@gmail.com>
|
|
* Add function type for `popperConfig` option
* Update .bundlewatch.config.json
* copy edits
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
Co-authored-by: Mark Otto <markdotto@gmail.com>
|
|
- Removes the &[style] selector that was used for resetting Popper styles
- Separate Popper-based alignment from static alignment with `data-bs-popover` attribute that separates the --bs-position and custom right/left properties
Co-Authored-By: Rohit Sharma <rohit2sharma95@gmail.com>
|
|
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
|
|
* Emit events on the dropdown button
Emit the events on `.dropdown-toggle` button and then bubble up
* Add migration note for events
* Update the docs for events
* Add unit test to check the event bubbling
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
|
|
|
|
* Change from Error to TypeError
* Convert the `NAME` to upper case to make the consistency in the error message
* Update the remaining tests to be stricter
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
|
|
Adds the ability to use objects implementing the virtual element interface as the value for the reference option of a dropdown config.
Co-authored-by: XhmikosR <xhmikosr@gmail.com>
|
|
|
|
Using RTLCSS directives, renaming things to use logical names and following best practices.
|
|
|
|
|
|
The npm package is named "popper.js" but the project is named "Popper", so use the latter consistently.
|
