From 666fe596bf4629777f995dd79046b1db632ffdfb Mon Sep 17 00:00:00 2001 From: XhmikosR Date: Fri, 30 Jul 2021 09:28:51 +0300 Subject: Enable `unicorn/no-array-for-each` rule --- .eslintrc.json | 1 - build/generate-sri.js | 4 +-- build/zip-examples.js | 16 ++++++------ js/src/base-component.js | 4 +-- js/src/carousel.js | 4 +-- js/src/collapse.js | 30 ++++++++++++---------- js/src/dom/event-handler.js | 16 ++++++------ js/src/dom/manipulator.js | 13 +++++----- js/src/dropdown.js | 13 +++++----- js/src/modal.js | 5 ++-- js/src/offcanvas.js | 8 +++--- js/src/scrollspy.js | 51 ++++++++++++++++++++----------------- js/src/tab.js | 5 ++-- js/src/tooltip.js | 22 ++++++++-------- js/src/util/index.js | 8 +++--- js/src/util/sanitizer.js | 4 +-- js/src/util/scrollbar.js | 4 ++- js/tests/helpers/fixture.js | 8 +++--- js/tests/unit/carousel.spec.js | 6 ++--- js/tests/unit/modal.spec.js | 7 +++-- js/tests/unit/popover.spec.js | 4 +-- js/tests/unit/tooltip.spec.js | 4 +-- js/tests/unit/util/backdrop.spec.js | 14 +++++----- 23 files changed, 133 insertions(+), 118 deletions(-) diff --git a/.eslintrc.json b/.eslintrc.json index 302c765985..8fbb687ce0 100644 --- a/.eslintrc.json +++ b/.eslintrc.json @@ -51,7 +51,6 @@ ], "unicorn/explicit-length-check": "off", "unicorn/no-array-callback-reference": "off", - "unicorn/no-array-for-each": "off", "unicorn/no-array-method-this-argument": "off", "unicorn/no-null": "off", "unicorn/no-unused-properties": "error", diff --git a/build/generate-sri.js b/build/generate-sri.js index 221873b8fe..47d02c4c3c 100644 --- a/build/generate-sri.js +++ b/build/generate-sri.js @@ -47,7 +47,7 @@ const files = [ } ] -files.forEach(file => { +for (const file of files) { fs.readFile(file.file, 'utf8', (err, data) => { if (err) { throw err @@ -61,4 +61,4 @@ files.forEach(file => { sh.sed('-i', new RegExp(`^(\\s+${file.configPropertyName}:\\s+["'])\\S*(["'])`), `$1${integrity}$2`, configFile) }) -}) +} diff --git a/build/zip-examples.js b/build/zip-examples.js index 312548e8af..6c8ae527ac 100644 --- a/build/zip-examples.js +++ b/build/zip-examples.js @@ -57,22 +57,22 @@ sh.mkdir('-p', [ sh.cp('-Rf', `${docsDir}/examples/*`, distFolder) -cssFiles.forEach(file => { +for (const file of cssFiles) { sh.cp('-f', `${docsDir}/dist/css/${file}`, `${distFolder}/assets/dist/css/`) -}) +} -jsFiles.forEach(file => { +for (const file of jsFiles) { sh.cp('-f', `${docsDir}/dist/js/${file}`, `${distFolder}/assets/dist/js/`) -}) +} -imgFiles.forEach(file => { +for (const file of imgFiles) { sh.cp('-f', `${docsDir}/assets/brand/${file}`, `${distFolder}/assets/brand/`) -}) +} sh.rm(`${distFolder}/index.html`) // get all examples' HTML files -sh.find(`${distFolder}/**/*.html`).forEach(file => { +for (const file of sh.find(`${distFolder}/**/*.html`)) { const fileContents = sh.cat(file) .toString() .replace(new RegExp(`"/docs/${versionShort}/`, 'g'), '"../') @@ -81,7 +81,7 @@ sh.find(`${distFolder}/**/*.html`).forEach(file => { .replace(/(') .replace(/( +)