From f7b55da4509e62b559f1e8181cf4b03e964775a4 Mon Sep 17 00:00:00 2001
From: XhmikosR <xhmikosr@gmail.com>
Date: Tue, 26 Feb 2019 13:13:01 +0200
Subject: dom/manipulator.js: minor simplification. (#28358)

Combine two checks since we return the same value for both.
---
 js/src/dom/manipulator.js | 29 ++++++++++++++---------------
 1 file changed, 14 insertions(+), 15 deletions(-)

(limited to 'js/src/dom')

diff --git a/js/src/dom/manipulator.js b/js/src/dom/manipulator.js
index 31d0252c65..6c7df69425 100644
--- a/js/src/dom/manipulator.js
+++ b/js/src/dom/manipulator.js
@@ -5,18 +5,20 @@
  * --------------------------------------------------------------------------
  */
 
-const regexDataKey = /[A-Z]/g
-
 function normalizeData(val) {
   if (val === 'true') {
     return true
-  } else if (val === 'false') {
+  }
+
+  if (val === 'false') {
     return false
-  } else if (val === 'null') {
-    return null
-  } else if (val === Number(val).toString()) {
+  }
+
+  if (val === Number(val).toString()) {
     return Number(val)
-  } else if (val === '') {
+  }
+
+  if (val === '' || val === 'null') {
     return null
   }
 
@@ -24,7 +26,7 @@ function normalizeData(val) {
 }
 
 function normalizeDataKey(key) {
-  return key.replace(regexDataKey, (chr) => chr.toLowerCase())
+  return key.replace(/[A-Z]/g, (chr) => chr.toLowerCase())
 }
 
 const Manipulator = {
@@ -45,18 +47,15 @@ const Manipulator = {
       ...element.dataset
     }
 
-    Object.keys(attributes)
-      .forEach((key) => {
-        attributes[key] = normalizeData(attributes[key])
-      })
+    Object.keys(attributes).forEach((key) => {
+      attributes[key] = normalizeData(attributes[key])
+    })
 
     return attributes
   },
 
   getDataAttribute(element, key) {
-    return normalizeData(element
-      .getAttribute(`data-${normalizeDataKey(key)}`)
-    )
+    return normalizeData(element.getAttribute(`data-${normalizeDataKey(key)}`))
   },
 
   offset(element) {
-- 
cgit v1.2.3