From 03842b5f259d6007db02c465e6c55929e551e9cd Mon Sep 17 00:00:00 2001 From: GeoSot Date: Tue, 11 May 2021 09:04:42 +0300 Subject: Refactor: move disposing properties into the base class (#33740) Moves more functionality to `base-component`, transferring the responsibility of disposal to parent class. Each component, dusting disposal, sets its protected properties to `null`. So the same can be done in one place for all children components . --- js/src/dropdown.js | 3 --- 1 file changed, 3 deletions(-) (limited to 'js/src/dropdown.js') diff --git a/js/src/dropdown.js b/js/src/dropdown.js index bb2d01c274..8bd3f01e70 100644 --- a/js/src/dropdown.js +++ b/js/src/dropdown.js @@ -217,11 +217,8 @@ class Dropdown extends BaseComponent { } dispose() { - this._menu = null - if (this._popper) { this._popper.destroy() - this._popper = null } super.dispose() -- cgit v1.2.3