From 3f7b31e0e021ad45943c565a02509b4c10e55091 Mon Sep 17 00:00:00 2001 From: GeoSot Date: Tue, 1 Feb 2022 10:33:18 +0200 Subject: Fix Popover test that randomly fails on BrowserStack (#35757) Co-authored-by: XhmikosR --- js/tests/unit/popover.spec.js | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) (limited to 'js') diff --git a/js/tests/unit/popover.spec.js b/js/tests/unit/popover.spec.js index 7bbd52b1db..bf3a71848c 100644 --- a/js/tests/unit/popover.spec.js +++ b/js/tests/unit/popover.spec.js @@ -166,21 +166,16 @@ describe('Popover', () => { }) it('should NOT show a popover without `title` and `content`', () => { - return new Promise(resolve => { - fixtureEl.innerHTML = 'Nice link' + fixtureEl.innerHTML = 'Nice link' - const popoverEl = fixtureEl.querySelector('a') - const popover = new Popover(popoverEl, { animation: false }) - spyOn(EventHandler, 'trigger').and.callThrough() + const popoverEl = fixtureEl.querySelector('a') + const popover = new Popover(popoverEl, { animation: false }) + spyOn(EventHandler, 'trigger').and.callThrough() - setTimeout(() => { - expect(EventHandler.trigger).not.toHaveBeenCalled() - expect(document.querySelector('.popover')).toBeNull() - resolve() - }) + popover.show() - popover.show() - }) + expect(EventHandler.trigger).not.toHaveBeenCalledWith(popoverEl, Popover.Event.SHOW) + expect(document.querySelector('.popover')).toBeNull() }) it('"setContent" should keep the initial template', () => { -- cgit v1.2.3