From 09dc5be9128bb07766b01bda9e053046478f9a03 Mon Sep 17 00:00:00 2001 From: Johannes Ewald Date: Tue, 4 Nov 2014 09:36:40 +0100 Subject: Fix shadowing of internal `module`, `exports` and `require` when a global counterpart exists @see https://github.com/jhnns/rewire-webpack/pull/6 --- lib/getImportGlobalsSrc.js | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'lib') diff --git a/lib/getImportGlobalsSrc.js b/lib/getImportGlobalsSrc.js index 66e69b1..10dfe87 100644 --- a/lib/getImportGlobalsSrc.js +++ b/lib/getImportGlobalsSrc.js @@ -16,6 +16,10 @@ function getImportGlobalsSrc(ignore) { ignore = ignore || []; // global itself can't be overridden because it's the only reference to our real global objects ignore.push("global"); + // ignore 'module', 'exports' and 'require' on the global scope, because otherwise our code would + // shadow the module-internal variables + // @see https://github.com/jhnns/rewire-webpack/pull/6 + ignore.push("module", "exports", "require"); for (key in globalObj) { /* jshint forin: false */ if (ignore.indexOf(key) !== -1) { -- cgit v1.2.3