From bbbd05cab7260f7db9ffcb4adb2e19bdf661bca9 Mon Sep 17 00:00:00 2001 From: Johannes Ewald Date: Tue, 28 Apr 2015 00:46:50 +0200 Subject: Fix issue where the strict mode was not detected when a comment was before "strict mode"; Fixes #54 --- test/detectStrictMode.test.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) (limited to 'test') diff --git a/test/detectStrictMode.test.js b/test/detectStrictMode.test.js index 5cde34e..06eb1c4 100644 --- a/test/detectStrictMode.test.js +++ b/test/detectStrictMode.test.js @@ -2,6 +2,7 @@ var expect = require("expect.js"), detectStrictMode = require("../lib/detectStrictMode.js"); describe("detectStrictMode", function () { + it("should detect all valid uses of \"use strict\";", function () { expect(detectStrictMode('"use strict";')).to.be(true); expect(detectStrictMode("'use strict';")).to.be(true); @@ -11,13 +12,22 @@ describe("detectStrictMode", function () { expect(detectStrictMode('"use strict"\r\n')).to.be(true); expect(detectStrictMode('"use strict" ; test();')).to.be(true); }); + + it("should be allowed to place comments before \"use strict\";", function () { + expect(detectStrictMode('// some comment\n"use strict";')).to.be(true); + expect(detectStrictMode('/* yo! */"use strict"; /* another comment */')).to.be(true); + expect(detectStrictMode(' // yes yo\r\n\r\n\r\n /*oh yoh*/\r\n//oh snap!\r /* yoh! */"use strict";')).to.be(true); + }); + it("should not detect invalid uses of \"use strict\";", function () { expect(detectStrictMode('" use strict ";')).to.be(false); expect(detectStrictMode('"use strict".replace("use", "fail");')).to.be(false); expect(detectStrictMode('"use strict" .replace("use", "fail");')).to.be(false); expect(detectStrictMode(';"use strict";')).to.be(false); }); + it("should not detect \"use strict\"; if it occurs in some nested function", function () { expect(detectStrictMode('function () {"use strict";}')).to.be(false); }); -}); \ No newline at end of file + +}); -- cgit v1.2.3