From fb5b841fdc65ed69adcbcbf4b33d17a0f61249e5 Mon Sep 17 00:00:00 2001 From: Johannes Ewald Date: Thu, 5 Feb 2015 21:11:50 +0100 Subject: Use mocha to check for global leaks --- test/rewire.test.js | 8 -------- test/testModules/sharedTestCases.js | 3 +++ 2 files changed, 3 insertions(+), 8 deletions(-) (limited to 'test') diff --git a/test/rewire.test.js b/test/rewire.test.js index 0524a36..1ac0129 100644 --- a/test/rewire.test.js +++ b/test/rewire.test.js @@ -16,14 +16,6 @@ describe("rewire", function () { fs.renameSync(fakeNodeModules, path.resolve(__dirname, "testModules/node_modules")); } }); - it("should keep not leak globals", function () { - // This test should run first, as the global space may be already polluted if - // require("../") is run before this test. - var originalGlobalKeys = Object.keys(global), - rewire = require("../"), - emptyModule = rewire("./testModules/emptyModule.js"); - expect(Object.keys(global)).to.eql(originalGlobalKeys); - }); it("should pass all shared test cases", function () { require("./testModules/sharedTestCases.js"); }); diff --git a/test/testModules/sharedTestCases.js b/test/testModules/sharedTestCases.js index 785b41b..20e017d 100644 --- a/test/testModules/sharedTestCases.js +++ b/test/testModules/sharedTestCases.js @@ -256,6 +256,9 @@ describe("rewire " + (typeof testEnv === "undefined"? "(node)": "(" + testEnv + // setting implicit global vars will change them globally instead of locally. // that's a shortcoming of the current implementation which can't be solved easily. //expect(implicitGlobal).to.be.a("string"); + + // Cleaning up... + delete global.implicitGlobal; }); it("should throw a TypeError if the path is not a string", function () { -- cgit v1.2.3