From fbec46432829623013742372637f597702d9993d Mon Sep 17 00:00:00 2001 From: Chris Rebert Date: Sun, 3 Jul 2016 17:53:45 -0700 Subject: Fix #35 by adding Edited & Unknown cases to PullRequestAction --- .../github/pr_action/PullRequestAction.scala | 25 +++++++++++++--------- .../getbootstrap/savage/github/util/package.scala | 2 +- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/src/main/scala/com/getbootstrap/savage/github/pr_action/PullRequestAction.scala b/src/main/scala/com/getbootstrap/savage/github/pr_action/PullRequestAction.scala index dc00ca0..9e2968b 100644 --- a/src/main/scala/com/getbootstrap/savage/github/pr_action/PullRequestAction.scala +++ b/src/main/scala/com/getbootstrap/savage/github/pr_action/PullRequestAction.scala @@ -1,17 +1,18 @@ package com.getbootstrap.savage.github.pr_action object PullRequestAction { - def apply(name: String): Option[PullRequestAction] = { + def apply(name: String): PullRequestAction = { name match { - case Assigned.Name => Some(Assigned) - case Unassigned.Name => Some(Unassigned) - case Labeled.Name => Some(Labeled) - case Unlabeled.Name => Some(Unlabeled) - case Opened.Name => Some(Opened) - case Closed.Name => Some(Closed) - case Reopened.Name => Some(Reopened) - case Synchronize.Name => Some(Synchronize) - case _ => None + case Assigned.Name => Assigned + case Unassigned.Name => Unassigned + case Labeled.Name => Labeled + case Unlabeled.Name => Unlabeled + case Opened.Name => Opened + case Closed.Name => Closed + case Reopened.Name => Reopened + case Synchronize.Name => Synchronize + case Edited.Name => Edited + case _ => Unknown(name) } } } @@ -42,3 +43,7 @@ object Reopened extends PullRequestAction { object Synchronize extends PullRequestAction { override val Name = "synchronize" } +object Edited extends PullRequestAction { + override val Name = "edited" +} +case class Unknown(Name: String) extends PullRequestAction diff --git a/src/main/scala/com/getbootstrap/savage/github/util/package.scala b/src/main/scala/com/getbootstrap/savage/github/util/package.scala index 15ffe0c..2852e0e 100644 --- a/src/main/scala/com/getbootstrap/savage/github/util/package.scala +++ b/src/main/scala/com/getbootstrap/savage/github/util/package.scala @@ -33,7 +33,7 @@ package object util { def asPullRemote: String = s"https://github.com/${repoId.generateId}.git" } implicit class RichPullRequestPayload(val payload: PullRequestPayload) extends AnyVal { - def action: PullRequestAction = PullRequestAction(payload.getAction).get + def action: PullRequestAction = PullRequestAction(payload.getAction) } implicit class RichUser(val user: User) extends AnyVal { def username: GitHubUser = GitHubUser(user.getLogin) -- cgit v1.2.3