diff options
author | Matthias Held <ilovemilk@wusa.io> | 2018-07-19 23:42:40 +0300 |
---|---|---|
committer | Matthias Held <ilovemilk@wusa.io> | 2018-07-19 23:42:40 +0300 |
commit | fea0a00fcd59e6dd4c7d7e7fecd0739beea8de69 (patch) | |
tree | ebdb9dca1dc4535321be1fe6aa46538929b27c21 | |
parent | f692b9165842244978181707cb421b34f805967d (diff) |
Fix code check errors
-rw-r--r-- | appinfo/database.xml | 2 | ||||
-rw-r--r-- | appinfo/info.xml | 2 | ||||
-rw-r--r-- | lib/Analyzer/SequenceAnalyzer.php | 2 | ||||
-rw-r--r-- | lib/Classifier.php | 16 | ||||
-rw-r--r-- | lib/Connector/Sabre/RequestPlugin.php | 6 | ||||
-rw-r--r-- | lib/Db/FileOperationMapper.php | 18 | ||||
-rw-r--r-- | lib/Settings/Admin.php | 6 | ||||
-rw-r--r-- | lib/Settings/Personal.php | 2 |
8 files changed, 27 insertions, 27 deletions
diff --git a/appinfo/database.xml b/appinfo/database.xml index f7f27f4..8f2b9b4 100644 --- a/appinfo/database.xml +++ b/appinfo/database.xml @@ -5,7 +5,7 @@ <overwrite>false</overwrite> <charset>utf8</charset> <table> - <name>*dbprefix*ransomware_detection_file_operation</name> + <name>*dbprefix*ransomware_detection_file</name> <declaration> <field> <name>id</name> diff --git a/appinfo/info.xml b/appinfo/info.xml index 0b073b3..cab2bde 100644 --- a/appinfo/info.xml +++ b/appinfo/info.xml @@ -7,7 +7,7 @@ <description><![CDATA[This app monitors file operations to detect ransomware attacks by using generic indicators for a guided user-controlled recovery utilizing the integrated file versioning methods.]]></description> <licence>agpl</licence> <author mail="matthias.held@uni-konstanz.de">Matthias Held</author> - <version>0.2.3</version> + <version>0.2.4</version> <namespace>RansomwareDetection</namespace> <category>files</category> <category>monitoring</category> diff --git a/lib/Analyzer/SequenceAnalyzer.php b/lib/Analyzer/SequenceAnalyzer.php index 35b7c29..219220c 100644 --- a/lib/Analyzer/SequenceAnalyzer.php +++ b/lib/Analyzer/SequenceAnalyzer.php @@ -148,7 +148,7 @@ class SequenceAnalyzer $sequenceResult->setSizeDeleted($sizeOfDeletedFiles); $upperBound = sizeof($deletedFiles) + self::NUMBER_OF_INFO_FILES; if (sizeof($writtenFiles) <= $upperBound && sizeof($writtenFiles) >= sizeof($deletedFiles)) { - if ($this->sequenceSizeAnalyzer->analyze($sequence) == SequenceSizeAnalyzer::EQUAL_SIZE) { + if ($this->sequenceSizeAnalyzer->analyze($sequence) === SequenceSizeAnalyzer::EQUAL_SIZE) { $sequenceResult->setQuantities(2); $suspicionScore += 2; } else { diff --git a/lib/Classifier.php b/lib/Classifier.php index 3311d41..0ae06b5 100644 --- a/lib/Classifier.php +++ b/lib/Classifier.php @@ -74,21 +74,21 @@ class Classifier public function classifyFile($file) { $file->setSuspicionClass(self::NO_INFORMATION); - if ($file->getCommand() == Monitor::WRITE || - $file->getCommand() == Monitor::RENAME || - $file->getCommand() == Monitor::DELETE || - $file->getCommand() == Monitor::CREATE + if ($file->getCommand() === Monitor::WRITE || + $file->getCommand() === Monitor::RENAME || + $file->getCommand() === Monitor::DELETE || + $file->getCommand() === Monitor::CREATE ) { - if ($file->getFileClass() == EntropyResult::ENCRYPTED) { - if ($file->getFileNameClass() == FileNameResult::SUSPICIOUS) { + if ($file->getFileClass() === EntropyResult::ENCRYPTED) { + if ($file->getFileNameClass() === FileNameResult::SUSPICIOUS) { $file->setSuspicionClass(self::HIGH_LEVEL_OF_SUSPICION); } elseif ($file->getFileNameClass() > FileNameResult::NORMAL) { $file->setSuspicionClass(self::MIDDLE_LEVEL_OF_SUSPICION); } else { $file->setSuspicionClass(self::NOT_SUSPICIOUS); } - } elseif ($file->getFileClass() == EntropyResult::COMPRESSED) { - if ($file->getFileNameClass() == FileNameResult::SUSPICIOUS) { + } elseif ($file->getFileClass() === EntropyResult::COMPRESSED) { + if ($file->getFileNameClass() === FileNameResult::SUSPICIOUS) { $file->setSuspicionClass(self::MIDDLE_LEVEL_OF_SUSPICION); } elseif ($file->getFileNameClass() > FileNameResult::NORMAL) { $file->setSuspicionClass(self::LOW_LEVEL_OF_SUSPICION); diff --git a/lib/Connector/Sabre/RequestPlugin.php b/lib/Connector/Sabre/RequestPlugin.php index e4cc918..72eb90e 100644 --- a/lib/Connector/Sabre/RequestPlugin.php +++ b/lib/Connector/Sabre/RequestPlugin.php @@ -175,11 +175,11 @@ class RequestPlugin extends ServerPlugin } // sequence suspicion level - if ($sequenceSuspicionLevel == 1) { + if ($sequenceSuspicionLevel === 1) { $level = 3; - } elseif ($sequenceSuspicionLevel == 2) { + } elseif ($sequenceSuspicionLevel === 2) { $level = 5; - } elseif ($sequenceSuspicionLevel == 3) { + } elseif ($sequenceSuspicionLevel === 3) { $level = 6; } diff --git a/lib/Db/FileOperationMapper.php b/lib/Db/FileOperationMapper.php index 1a672d4..9d78537 100644 --- a/lib/Db/FileOperationMapper.php +++ b/lib/Db/FileOperationMapper.php @@ -32,7 +32,7 @@ class FileOperationMapper extends Mapper public function __construct( IDBConnection $db ) { - parent::__construct($db, 'ransomware_detection_file_operation'); + parent::__construct($db, 'ransomware_detection_file'); } /** @@ -47,7 +47,7 @@ class FileOperationMapper extends Mapper */ public function find($id, $userId) { - $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file_operation` '. + $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file` '. 'WHERE `id` = ? AND `user_id` = ?'; return $this->findEntity($sql, [$id, $userId]); @@ -65,7 +65,7 @@ class FileOperationMapper extends Mapper */ public function findOneByFileName($name, $userId) { - $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file_operation` '. + $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file` '. 'WHERE `original_name` = ? AND `user_id` = ?'; return $this->findEntity($sql, [$name, $userId]); @@ -81,7 +81,7 @@ class FileOperationMapper extends Mapper */ public function findOneWithHighestId($userId) { - $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file_operation` WHERE `user_id` = ?'. + $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file` WHERE `user_id` = ?'. 'ORDER BY id DESC LIMIT 1'; return $this->findEntity($sql, [$userId]); @@ -97,7 +97,7 @@ class FileOperationMapper extends Mapper */ public function findAll(array $params = [], $limit = null, $offset = null) { - $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file_operation` WHERE `user_id` = ?'; + $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file` WHERE `user_id` = ?'; return $this->findEntities($sql, $params, $limit, $offset); } @@ -113,7 +113,7 @@ class FileOperationMapper extends Mapper */ public function findSequenceById(array $params = [], $limit = null, $offset = null) { - $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file_operation` WHERE `sequence` = ? AND `user_id` = ?'; + $sql = 'SELECT * FROM `*PREFIX*ransomware_detection_file` WHERE `sequence` = ? AND `user_id` = ?'; return $this->findEntities($sql, $params, $limit, $offset); } @@ -125,7 +125,7 @@ class FileOperationMapper extends Mapper */ public function deleteById($id, $userId) { - $sql = 'DELETE FROM `*PREFIX*ransomware_detection_file_operation` WHERE `id` = ? AND `user_id` = ?'; + $sql = 'DELETE FROM `*PREFIX*ransomware_detection_file` WHERE `id` = ? AND `user_id` = ?'; $stmt = $this->execute($sql, [$id, $userId]); $stmt->closeCursor(); } @@ -137,7 +137,7 @@ class FileOperationMapper extends Mapper */ public function deleteSequenceById($sequence, $userId) { - $sql = 'DELETE FROM `*PREFIX*ransomware_detection_file_operation` WHERE `sequence` = ? AND `user_id` = ?'; + $sql = 'DELETE FROM `*PREFIX*ransomware_detection_file` WHERE `sequence` = ? AND `user_id` = ?'; $stmt = $this->execute($sql, [$sequence, $userId]); $stmt->closeCursor(); } @@ -149,7 +149,7 @@ class FileOperationMapper extends Mapper */ public function deleteFileOperationsBefore($timestamp) { - $sql = 'DELETE FROM `*PREFIX*ransomware_detection_file_operation` WHERE `timestamp` < ?'; + $sql = 'DELETE FROM `*PREFIX*ransomware_detection_file` WHERE `timestamp` < ?'; $stmt = $this->execute($sql, [$timestamp]); $stmt->closeCursor(); } diff --git a/lib/Settings/Admin.php b/lib/Settings/Admin.php index efd0296..0288ab0 100644 --- a/lib/Settings/Admin.php +++ b/lib/Settings/Admin.php @@ -49,13 +49,13 @@ class Admin implements ISettings { $suspicionLevel = $this->config->getAppValue(Application::APP_ID, 'suspicionLevel', 3); - if ($suspicionLevel == 1) { + if ($suspicionLevel === 1) { $activeSuspicionLevel = ['code' => 1, 'name' => 'Low']; $suspicionLevels = [['code' => 2, 'name' => 'Middle'], ['code' => 3, 'name' => 'High']]; - } elseif ($suspicionLevel == 2) { + } elseif ($suspicionLevel === 2) { $activeSuspicionLevel = ['code' => 2, 'name' => 'Middle']; $suspicionLevels = [['code' => 1, 'name' => 'Low'], ['code' => 3, 'name' => 'High']]; - } elseif ($suspicionLevel == 3) { + } elseif ($suspicionLevel === 3) { $activeSuspicionLevel = ['code' => 3, 'name' => 'High']; $suspicionLevels = [['code' => 2, 'name' => 'Middle'], ['code' => 1, 'name' => 'Low']]; } else { diff --git a/lib/Settings/Personal.php b/lib/Settings/Personal.php index 88211e6..1e7ee8e 100644 --- a/lib/Settings/Personal.php +++ b/lib/Settings/Personal.php @@ -69,7 +69,7 @@ class Personal implements ISettings { $colorMode = $this->config->getUserValue($this->userId, Application::APP_ID, 'colorMode', 0); - if ($colorMode == 0) { + if ($colorMode === 0) { $colorActive = ['code' => 0, 'name' => 'Normal']; $color = ['code' => 1, 'name' => 'Color blind']; } else { |