From f1f59d274893c100b96d2f92d4cb09d42f000129 Mon Sep 17 00:00:00 2001 From: Alex Newman Date: Fri, 1 Jan 2016 18:29:27 -0800 Subject: Fixed incorrect null check localResolveResult was checked twice, but resolveResult null check was skipped. --- .../PracticesAndImprovements/ParameterCanBeDeclaredWithBaseTypeIssue.cs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ICSharpCode.NRefactory.CSharp.Refactoring/CodeIssues/Synced/PracticesAndImprovements/ParameterCanBeDeclaredWithBaseTypeIssue.cs b/ICSharpCode.NRefactory.CSharp.Refactoring/CodeIssues/Synced/PracticesAndImprovements/ParameterCanBeDeclaredWithBaseTypeIssue.cs index 9f4da08f..233a3b60 100644 --- a/ICSharpCode.NRefactory.CSharp.Refactoring/CodeIssues/Synced/PracticesAndImprovements/ParameterCanBeDeclaredWithBaseTypeIssue.cs +++ b/ICSharpCode.NRefactory.CSharp.Refactoring/CodeIssues/Synced/PracticesAndImprovements/ParameterCanBeDeclaredWithBaseTypeIssue.cs @@ -356,7 +356,7 @@ namespace ICSharpCode.NRefactory.CSharp.Refactoring if (localResolveResult == null) return; var resolveResult = context.Resolve(indexerExpression); - if (localResolveResult == null) + if (resolveResult == null) return; var parent = indexerExpression.Parent; while (parent is ParenthesizedExpression) -- cgit v1.2.3