diff options
author | Eric Maupin <ermaup@microsoft.com> | 2018-03-31 00:32:53 +0300 |
---|---|---|
committer | Dominique Louis <savagesoftware@gmail.com> | 2018-04-10 01:01:25 +0300 |
commit | 3590a247ba834e79dd3f13e446d566ebd74ae72d (patch) | |
tree | f109dc2ab569d320e2b4296f4be5fd2947e69724 /Xamarin.PropertyEditing | |
parent | ca76218dcd19ecadd5052766e07b6fc0ce39578d (diff) |
[Core] Trigger Value update after individual choices up to date
While the most correct thing is for the UI to reflect the values of the
individual choices when they are changed, a reasonable usage is to wait
for the value to update and then trigger the update. Reordering Value to
update after the flags ensure that they are up to date when Value is
triggered through INPC.
Given that the flags are really the source of truth for the values in
the combinable property, it makes sense for them to be first.
Diffstat (limited to 'Xamarin.PropertyEditing')
-rw-r--r-- | Xamarin.PropertyEditing/ViewModels/CombinablePropertyViewModel.cs | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/Xamarin.PropertyEditing/ViewModels/CombinablePropertyViewModel.cs b/Xamarin.PropertyEditing/ViewModels/CombinablePropertyViewModel.cs index 5942cc2..505284f 100644 --- a/Xamarin.PropertyEditing/ViewModels/CombinablePropertyViewModel.cs +++ b/Xamarin.PropertyEditing/ViewModels/CombinablePropertyViewModel.cs @@ -78,8 +78,6 @@ namespace Xamarin.PropertyEditing.ViewModels return; using (await AsyncWork.RequestAsyncWork (this)) { - await base.UpdateCurrentValueAsync (); - var newValues = new Dictionary<string, bool?> (this.predefinedValues.PredefinedValues.Count); ValueInfo<IReadOnlyList<TValue>>[] values = await Task.WhenAll (Editors.Select (ed => ed.GetValueAsync<IReadOnlyList<TValue>> (Property, Variation)).ToArray ()); @@ -112,6 +110,8 @@ namespace Xamarin.PropertyEditing.ViewModels } } this.fromUpdate = false; + + await base.UpdateCurrentValueAsync (); } } |