[Core] Use `await` instead of `.Result`

This ensures that OperationCanceledExceptions are correctly propagated
in the event of asynchronous cancelation. There is also an additional
'token.ThrowIfCancellationRequested' check in case we bail out of
the while loop because our token is cancelled. In this scenario we
should cancel instead of setting our partial data.

1 files changed, 3 insertions, 2 deletions

diff --git a/Xamarin.PropertyEditing/ViewModels/PropertyViewModel.cs b/Xamarin.PropertyEditing/ViewModels/PropertyViewModel.cs
index 8397e8f..231c129 100644
--- a/Xamarin.PropertyEditing/ViewModels/PropertyViewModel.cs
+++ b/Xamarin.PropertyEditing/ViewModels/PropertyViewModel.cs
@@ -484,12 +484,13 @@ namespace Xamarin.PropertyEditing.ViewModels
 					tasks.Remove (results);
 
 					if (list == null) {
-						list = results.Result;
+						list = await results;
 						common = new HashSet<string> (list);
 					} else
-						common.IntersectWith (results.Result);
+						common.IntersectWith (await results);
 				} while (tasks.Count > 0 && !cancel.IsCancellationRequested);
 
+				cancel.ThrowIfCancellationRequested ();
 				this.autocomplete.Reset (list.Where (common.Contains));
 			} catch (OperationCanceledException) {
 			}