| Age | Commit message (Collapse) | Author |
|---|
|
|
|
This all needs to move to the EditorContainer left view
|
|
DefaultControlHeight had ended up everywhere with no real meaning attached to it,
used in some places with manual offsets. It was never clear whether it was the row
size or a control size. Given the design doesn't always have matching heights for
controls, we should just do away with this illusion.
Additionally each editor had a manual offset trying to account for the property
button and associated spacing on the right and wasn't consistent between 32 or 33.
We do away with all that by moving the property button into the EditorContainer
with a new flag on IEditorView denoting whether we should have a property button
or not. Now all editors should not concern themselves with right inset and match
width fully.
Unfortunately the design sometimes has inconsistent top/bottom insets that vary
from 3/3 to 3.5/3.5. I'd like to make them consistent, so we can set them at
the EditorContainer level but for now the best thing that can be done is inset
on a per editor basis.
This also attempts to address labels and sometimes the property button not being
vertically centered on the first editors. Now, the label is CenterY on the
FirstKeyView which should center it vertically against the topmost input. The
property button is now also CenterYd to the label, so it similarlly should auto
center against the first row of input. If this proves to be not flexible enough
we can revisit.
This also makes more controls consistent with a control size of Small and uses
the system provided mechanism for making sure the font matches so it fits
correctly.
These new guidelines should be used:
- Rows have a height of 24
- Editors should match width
- Single-row editors should CenterY on the parent, match width -6
- Multi-row editors should inset appropriately at -3/-3
- We should avoid so many manually calculated offsets going forward
|
|
|
|
|
|
|
|
|
|
|
|
This makes sure they end up in the right directory
|
|
Type selector editor
|
|
|
|
|
|
|
|
Add pe- prefix to all image resources.
|
|
xamarin/dominique-SetTooltipIncasePropertyLabelClipped
[Mac] Set Tooltip value for when resizing occurs & long properties are…
|
|
|
|
AllowsExpansionToolTips by default.
|
|
This is largely required to get control over the left most column for
coloring and icon use.
|
|
|
|
|
|
Imagine properties A and B with the same editor type. Both properties
are initially shown and then removed as the selected object is cleared.
The order in which the editors are queued and dequeued for reuse is an
unknown, so we can not depend on a behavior. Imagine then that property
A is re-shown, but not B. It's possible that the editor for B is reused
for property A. Without the change, you now have two editors hooked up
to A's events. Besides keeping the VM alive, if any of the events
trigger UI tasks that require a superview/window, they will fail and
crash.
|
|
|
|
|
|
|
|
|
|
distribution.
|
|
distribution.
|
|
[Mac] Creates a new focusable ComboBox with readonly modifier
|
|
|
|
Fixes #497
|
|
DynamicFillBox now allows for colors to be not found, sort of a hack fix
to deal with the fact that we allow PropertyEditorPanel to be used in
xibs, so we can't demand a IHostResourceProvider in the ctor, we have to
accept it later.
This also fixes the fact that the header theming wouldn't update when
the resource provider changes.
|
|
Hack fix, we should really see if there's a <Mojave way of tinting images
reasonably.
|
|
Was a change trying to get the disabled look, got left in when submitting.
|
|
Revamp Mac theming
|
|
|
|
|
|
Fixes https://github.com/xamarin/Xamarin.PropertyEditing/issues/496
|
|
|
|
|
|
|
|
|
|
|
|
Seems Mojave calls ViewDidChangeEffectiveAppearance in NSView.ctor (NSCoder)
where High Sierra did not. We'll just ignore appearance changes until we're
setup.
|
|
|
|
This fixes an issue where a transparent background would bleed a popup's background through
rather than the view or layers below it.
Also tweak sizes to fit everything.
|
|
|
|
|
|
|
|
|
|
This fixes foreground color for this view not changing when a row containing it is selected
|
