Age | Commit message (Collapse) | Author |
|
When the property panel is hidden via the auto-hide button,
controls are unloaded (the Unload event is generated). Then when
it's reshown it's loaded again (Load event). This may be the only
case where controls are loaded after being unloaded. Previously,
the code didn't seem to assume reloads would happen, clearing
out the DataContext on unload. But that seems wrong, as DataContext
isn't reset on the load, which caused controls not to work (all be
blank) in the panel hide/show scenario.
Updated to no longer null out the DataContext on unload. That fixed
this bug and doesn't seem to have any other ill effects.
Fixes AB#1315193
|
|
Fix AB#1251444. The rule is that the border for edit boxes (and all controls) when focused must have at least a 3:1 contrast difference with the border when unfocused - there must enough contrast difference to make obvious to all that the visual state changed. That wasn't the case for our edit boxes before but is now. Updated to use the same themed border & text colors as the as the Cider colors, used by the WPF designer, which we've kept consistent with in the past.
Checkboxes and buttons already show a dashed outline for a focus rect. That's not the current standard for VS UI controls, but it's what it's always done and is fine from an a11y point of view, since there's even more obvious contrast, so that didn't change here. It was only text boxes that had an a11y problem.
|
|
Hitting tab should never set focus to the property editor panel itself. Fixed AB#1251446
|
|
Set AutomationProperty.Name on the "advanced properties" expander
control (with value "Advanced Properties") for a11y.
Fixes AB#1214551
|
|
* Refactor to have individual Date and Time Controls for better mapping for .Forms
* Add default control mapping to the TypeMap
* Call our initialise value method.
* Use custom controls and converters for our custom Date/Time
* Let's return the 'broken' string, if an error occurs, until they correct it.
|
|
* Ensure all the screen elements in this Window have their AutomationProperties.Name property set, for accessibility.
* Fix Resources file, hopefully.
* Attempt 2 at fixing Resources file.
* Change Null Category test, as we now expect Unnamed instead of null.
|
|
|
|
This fixes AB#1003978
Previously the choice buttons (used for picking brush type) showed focus via a different background color. But that color difference wasn't sufficiently obvious, per a11y testing. Our UI designer suggested that using a focus rect instead would be better, which is also what XET does here. And it indeed does look pretty good, IMO.
|
|
xamarin/bret-make-narrator-not-announce-menu-position
Make narrator not announce menu item posistion
|
|
|
|
.NET Framework 4.8 added the PositionInSet automation property. It also changed the semantics so that if this
property is not set it's computed automatically. And it's read by the narrator. The net result is that when
proppy is run in a .NET Framework 4.8 app (like Visual Studio), the narrator reads off the position of menu items
(e.g. "blah blah menu item 4 of 11"). AND hidden menu items are counted here, which makes those positions wrong,
causing this bug: https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1000455.
To work around all of that, we set the PositionInSet property explicitly, when running on .NET Framework 4.8,
to be 0. That causes the narrator not to read the position at all, which is how most VS menus behave.
|
|
Windows has the surprising behavior that when an automation group (like a group of combinable checkboxes) has a colon in the name, the group label is not read by the narrator. This causes a problem for the Android designer, which has property names like "app:layout_anchorGravity". We work around this by replacing the colon with a space in the group's automation name.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
In WPF, even if a control is collapsed, automation will still pick
it up. So we need to use our own automation peers to eliminate it
from the automation tree if it's not visible.
|
|
|
|
|
|
|
|
|
|
|
|
And add name for menu
|
|
|
|
|
|
This provides a group for each individual property presenter which
encapsulates the contents within under the property's name, solving
situations where despite the automation name being set, it's not read
aloud.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
This tightens up the naming distinctions:
- Variation - The set of VariationOptions defining when the Variant will
be active.
- Variant - The collective property, Variation and its value.
It also asyncifies the request for Mac
|
|
|
|
|
|
|
|
|
|
Instead of making sure that the [0] binding updates correctly with the
binding system in WPF, it's simpler to just reuse the same system as mac
to set the top level itemssource. This collection is currently reset
when the filter opens up.
|
|
It's still 1px off, not sure why, but a lot closer than it was.
|
|
|
|
By aligning rows at a minimum 24 height at 0,2,0,2 padding we can create
a row to center the text in to keep it aligned with the editor text in
that row.
|
|
|
|
|
|
|
|
|
|
the name of the PropertyEditorControl to satisfy MAS 4.1.2 (#547)
|