From 8b1049979f1ecd4561fcad3fa8dc7181ae06594b Mon Sep 17 00:00:00 2001 From: Eric Maupin Date: Thu, 4 Oct 2018 12:20:50 -0400 Subject: [Tests] We generally don't check correctness of property changed As long as it signals when something potentially changed, that's good enough. Any consuming code should still operate correctly if it signals a change when there wasn't one, it's just a perf it. We can revisit if the perf hit ever becomes noticeable. --- Xamarin.PropertyEditing.Tests/PropertyViewModelTests.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Xamarin.PropertyEditing.Tests/PropertyViewModelTests.cs b/Xamarin.PropertyEditing.Tests/PropertyViewModelTests.cs index 6fe0f04..bb719e8 100644 --- a/Xamarin.PropertyEditing.Tests/PropertyViewModelTests.cs +++ b/Xamarin.PropertyEditing.Tests/PropertyViewModelTests.cs @@ -1285,7 +1285,7 @@ namespace Xamarin.PropertyEditing.Tests Assert.That (vm.InputMode, Is.EqualTo (modes[mode])); Assert.That (modeChanged, Is.True); Assert.That (vm.IsInputEnabled, Is.EqualTo (!modes[mode].IsSingleValue)); - Assert.That (enabledChanged, Is.EqualTo (modes[mode].IsSingleValue)); + Assert.That (enabledChanged, Is.True); } [TestCase (true)] @@ -1330,7 +1330,7 @@ namespace Xamarin.PropertyEditing.Tests vm.InputMode = modes[1]; - Assert.That (changed, Is.EqualTo (writeEnabled != expectation)); + Assert.That (changed, Is.True); Assert.That (vm.IsInputEnabled, Is.EqualTo (expectation)); } -- cgit v1.2.3