1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
|
<?php
/*
** Zabbix
** Copyright (C) 2001-2021 Zabbix SIA
**
** This program is free software; you can redistribute it and/or modify
** it under the terms of the GNU General Public License as published by
** the Free Software Foundation; either version 2 of the License, or
** (at your option) any later version.
**
** This program is distributed in the hope that it will be useful,
** but WITHOUT ANY WARRANTY; without even the implied warranty of
** MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
** GNU General Public License for more details.
**
** You should have received a copy of the GNU General Public License
** along with this program; if not, write to the Free Software
** Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA.
**/
require_once dirname(__FILE__).'/../include/CAPITest.php';
/**
* @backup triggers
*/
class testTriggerValidation extends CAPITest {
const TEMPLATE_TRIGGERID = 50178;
const UPDATE_TRIGGER_1 = 50176;
const UPDATE_TRIGGER_2 = 50177;
public static function triggers_to_update_data() {
return [
// Successful cases.
'disable trigger' => [
'triggers' => [
[
'status' => 1,
'triggerid' => self::UPDATE_TRIGGER_1
]
],
'expected_error' => null
],
'add dependent trigger' => [
'triggers' => [
[
'triggerid' => self::UPDATE_TRIGGER_1,
'dependencies' => [
[
'triggerid' => self::UPDATE_TRIGGER_2
]
]
]
],
'expected_error' => null
],
'delete dependent trigger' => [
'triggers' => [
[
'triggerid' => self::UPDATE_TRIGGER_1,
'dependencies' => []
]
],
'expected_error' => null
],
'change recovery mode to "none"' => [
'triggers' => [
[
'triggerid' => self::UPDATE_TRIGGER_1,
'recovery_mode' => 2
]
],
'expected_error' => null
],
// Failed cases.
'swap names between 2 triggers' => [
'triggers' => [
[
'description' => 'test-trigger-2',
'triggerid' => self::UPDATE_TRIGGER_1
],
[
'description' => 'test-trigger-1',
'triggerid' => self::UPDATE_TRIGGER_2
]
],
'expected_error' => 'Trigger "test-trigger-2" already exists on "Trigger validation test host".'
],
'check circular dependencies' => [
'triggers' => [
[
'triggerid' => self::UPDATE_TRIGGER_1,
'dependencies' => [
[
'triggerid' => self::UPDATE_TRIGGER_2
]
]
],
[
'triggerid' => self::UPDATE_TRIGGER_2,
'dependencies' => [
[
'triggerid' => self::UPDATE_TRIGGER_1
]
]
]
],
'expected_error' => 'Cannot create circular dependencies.'
],
'delete trigger name' => [
'triggers' => [
[
'triggerid' => self::UPDATE_TRIGGER_1,
'description' => ''
]
],
'expected_error' => 'Invalid parameter "/1/description": cannot be empty.'
],
'make trigger dependent on itself' => [
'triggers' => [
[
'triggerid' => self::UPDATE_TRIGGER_1,
'dependencies' => [
[
'triggerid' => self::UPDATE_TRIGGER_1
]
]
]
],
'expected_error' => 'Cannot create dependency on trigger itself.'
],
'update read-only properties' => [
'triggers' => [
[
'triggerid' => self::UPDATE_TRIGGER_1,
'flags' => 4
]
],
'expected_error' => 'Invalid parameter "/1": unexpected parameter "flags".'
],
'add unexisting dependent trigger' => [
'triggers' => [
[
'triggerid' => self::UPDATE_TRIGGER_1,
'dependencies' => [
[
'triggerid' => 0
]
]
]
],
'expected_error' => 'No permissions to referred object or it does not exist!'
]
];
}
public static function triggers_to_create_data() {
return [
// Successful cases.
'2 triggers with different names' => [
'triggers' => [
[
'description' => 'Trigger with unique name 1',
'expression' => 'last(/Trigger validation test host/item)=0'
],
[
'description' => 'Trigger with unique name 2',
'expression' => 'last(/Trigger validation test host/item)=0'
]
],
'expected_error' => null
],
'trigger with empty array values for tags and dependencies' => [
'triggers' => [
[
'description' => 'Trigger with null values for array properties',
'expression' => 'last(/Trigger validation test host/item)=0',
'tags' => [],
'dependencies' => []
]
],
'expected_error' => null
],
'trigger with recovery expression' => [
'triggers' => [
[
'description' => 'Trigger with recovery expression',
'expression' => 'last(/Trigger validation test host/item)=0',
'recovery_mode' => 1,
'recovery_expression' => 'last(/Trigger validation test host/item)=1'
]
],
'expected_error' => null
],
'trigger with correlation tag' => [
'triggers' => [
[
'description' => 'Trigger with correlation tag',
'expression' => 'last(/Trigger validation test host/item)=0',
'recovery_mode' => 0,
'correlation_mode' => 1,
'correlation_tag' => 'tag'
]
],
'expected_error' => null
],
'trigger with tags' => [
'triggers' => [
[
'description' => 'Trigger with tags',
'expression' => 'last(/Trigger validation test host/item)=0',
'tags' => [
[
'tag' => 'tag1'
],
[
'tag' => 'tag2'
]
]
]
],
'expected_error' => null
],
'trigger with dependencies' => [
'triggers' => [
[
'description' => 'Trigger with dependencies',
'expression' => 'last(/Trigger validation test host/item)=0',
'dependencies' => [
[
'triggerid' => self::UPDATE_TRIGGER_1
]
]
]
],
'expected_error' => null
],
// Failed cases.
'2 triggers with similar names' => [
'triggers' => [
[
'description' => 'Duplicate trigger name',
'expression' => 'last(/Trigger validation test host/item)=0'
],
[
'description' => 'Duplicate trigger name',
'expression' => 'last(/Trigger validation test host/item)=0'
]
],
'expected_error' => 'Invalid parameter "/2": value (description, expression)=(Duplicate trigger name, last(/Trigger validation test host/item)=0) already exists.'
],
'Trigger with invalid severity #1' => [
'triggers' => [
[
'description' => 'Trigger with invalid severity',
'expression' => 'last(/Trigger validation test host/item)=0',
'priority' => null
]
],
'expected_error' => 'Invalid parameter "/1/priority": an integer is expected.'
],
'Trigger with invalid severity #2' => [
'triggers' => [
[
'description' => 'Trigger with invalid severity',
'expression' => 'last(/Trigger validation test host/item)=0',
'priority' => 9
]
],
'expected_error' => 'Invalid parameter "/1/priority": value must be one of 0, 1, 2, 3, 4, 5.'
],
'Trigger with unexpected recovery exporession' => [
'triggers' => [
[
'description' => 'Trigger with unexpected recovery exporession',
'expression' => 'last(/Trigger validation test host/item)=0',
'recovery_expression' => 'last(/Trigger validation test host/item)=1'
]
],
'expected_error' => 'Incorrect value for field "recovery_expression": should be empty.'
],
'Trigger with unspecified recovery exporession' => [
'triggers' => [
[
'description' => 'Trigger with unspecified recovery exporession',
'expression' => 'last(/Trigger validation test host/item)=0',
'recovery_mode' => 1
]
],
'expected_error' => 'Incorrect value for field "recovery_expression": cannot be empty.'
],
'Trigger with invalid recovery exporession #1' => [
'triggers' => [
[
'description' => 'Trigger with expected recovery exporession',
'expression' => 'last(/Trigger validation test host/item)=0',
'recovery_mode' => 1,
'recovery_expression' => ['last(/Trigger validation test host/item)=1']
]
],
'expected_error' => 'Invalid parameter "/1/recovery_expression": a character string is expected.'
],
'Trigger with invalid recovery exporession #2' => [
'triggers' => [
[
'description' => 'Trigger with expected recovery exporession',
'expression' => 'last(/Trigger validation test host/item)=0',
'recovery_mode' => 1,
'recovery_expression' => '1+1'
]
],
'expected_error' => 'Invalid parameter "/1/recovery_expression": trigger expression must contain at least one /host/key reference.'
],
'Trigger with unexpected correlation tag #1' => [
'triggers' => [
[
'description' => 'Trigger with unexpected correlation tag',
'expression' => 'last(/Trigger validation test host/item)=0',
'correlation_mode' => 0,
'correlation_tag' => 'tag'
]
],
'expected_error' => 'Incorrect value for field "correlation_tag": should be empty.'
],
'Trigger with expected correlation tag #2' => [
'triggers' => [
[
'description' => 'Trigger with unexpected correlation tag',
'expression' => 'last(/Trigger validation test host/item)=0',
'recovery_mode' => 2,
'correlation_tag' => 'tag'
]
],
'expected_error' => 'Incorrect value for field "correlation_tag": should be empty.'
],
'Trigger with expected correlation tag' => [
'triggers' => [
[
'description' => 'Trigger with unexpected correlation tag',
'expression' => 'last(/Trigger validation test host/item)=0',
'correlation_mode' => 1,
'correlation_tag' => ''
]
],
'expected_error' => 'Incorrect value for field "correlation_tag": cannot be empty.'
],
'Trigger with invalid tags #1' => [
'triggers' => [
[
'description' => 'Trigger with invalid tags',
'expression' => 'last(/Trigger validation test host/item)=0',
'tags' => [[]]
]
],
'expected_error' => 'Invalid parameter "/1/tags/1": the parameter "tag" is missing.'
],
'Trigger with invalid tags #2' => [
'triggers' => [
[
'description' => 'Trigger with invalid tags',
'expression' => 'last(/Trigger validation test host/item)=0',
'tags' => [[
'tag' => '',
'value' => 'value'
]]
]
],
'expected_error' => 'Invalid parameter "/1/tags/1/tag": cannot be empty.'
],
'Trigger with invalid dependencies #1' => [
'triggers' => [
[
'description' => 'Trigger with invalid dependencies',
'expression' => 'last(/Trigger validation test host/item)=0',
'dependencies' => [[
'triggerid' => ''
]]
]
],
'expected_error' => 'Invalid parameter "/1/dependencies/1/triggerid": a number is expected.'
],
'Trigger with invalid dependencies #2' => [
'triggers' => [
[
'description' => 'Trigger with invalid dependencies',
'expression' => 'last(/Trigger validation test host/item)=0',
'dependencies' => [[
'triggerid' => self::TEMPLATE_TRIGGERID
]]
]
],
'expected_error' => 'Cannot add dependency from a host to a template.'
],
'Trigger with invalid dependencies #3' => [
'triggers' => [
[
'description' => 'Trigger with invalid dependencies',
'expression' => 'last(/Trigger validation test host/item)=0',
'dependencies' => [[
'triggerid' => 0
]]
]
],
'expected_error' => 'No permissions to referred object or it does not exist!'
],
'trigger with non-unique tags #1' => [
'triggers' => [
[
'description' => 'Trigger with non-unique tags',
'expression' => 'last(/Trigger validation test host/item)=0',
'tags' => [
[
'tag' => 'tag'
],
[
'tag' => 'tag'
]
]
]
],
'expected_error' => 'Invalid parameter "/1/tags/2": value (tag, value)=(tag, ) already exists.'
],
'trigger with non-unique tags #2' => [
'triggers' => [
[
'description' => 'Trigger with non-unique tags',
'expression' => 'last(/Trigger validation test host/item)=0',
'tags' => [
[
'tag' => 'tag',
'value' => 'value'
],
[
'tag' => 'tag',
'value' => 'value'
]
]
]
],
'expected_error' => 'Invalid parameter "/1/tags/2": value (tag, value)=(tag, value) already exists.'
],
'trigger with null in tags property' => [
'triggers' => [
[
'description' => 'Trigger with null values for array properties',
'expression' => 'last(/Trigger validation test host/item)=0',
'tags' => null
]
],
'expected_error' => 'Invalid parameter "/1/tags": an array is expected.'
],
'trigger with null in dependencies property' => [
'triggers' => [
[
'description' => 'Trigger with null values for array properties',
'expression' => 'last(/Trigger validation test host/item)=0',
'dependencies' => null
]
],
'expected_error' => 'Invalid parameter "/1/dependencies": an array is expected.'
],
'trigger with incorrectly formatted tags' => [
'triggers' => [
[
'description' => 'Trigger with tags',
'expression' => 'last(/Trigger validation test host/item)=0',
'tags' => [
'tag' => 'tag1',
'tag' => 'tag2'
]
]
],
'expected_error' => 'Invalid parameter "/1/tags/1": an array is expected.'
],
'trigger with incorrectly formatted dependencies' => [
'triggers' => [
[
'description' => 'Trigger with dependencies',
'expression' => 'last(/Trigger validation test host/item)=0',
'dependencies' => [
'triggerid' => self::UPDATE_TRIGGER_1
]
]
],
'expected_error' => 'Invalid parameter "/1/dependencies/1": an array is expected.'
]
];
}
/**
* Test trigger.create API.
*
* @dataProvider triggers_to_create_data
*/
public function testTriggerCreate($triggers, $expected_error) {
$this->call('trigger.create', $triggers, $expected_error);
}
/**
* Test trigger.update API.
*
* @dataProvider triggers_to_update_data
*/
public function testTriggerUpdate($triggers, $expected_error) {
$this->call('trigger.update', $triggers, $expected_error);
}
}
|