diff options
| author | Mayra Cabrera <mcabrera@gitlab.com> | 2020-06-23 00:37:00 +0300 |
|---|---|---|
| committer | Mayra Cabrera <mcabrera@gitlab.com> | 2020-06-23 00:49:26 +0300 |
| commit | 213ba66e43895c881f4f97b0e8d5942f03fd4a46 (patch) | |
| tree | 0d982abefe1bcbb20399196f94f4ec54a7296d74 /.gitlab/merge_request_templates | |
| parent | 297d9264f059dd502baa0a519a935e88d9dba44f (diff) | |
Update issue security release template
Also adds a security merge request template
Related to https://gitlab.com/gitlab-com/gl-infra/delivery/-/issues/766
Diffstat (limited to '.gitlab/merge_request_templates')
| -rw-r--r-- | .gitlab/merge_request_templates/Security Release.md | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/.gitlab/merge_request_templates/Security Release.md b/.gitlab/merge_request_templates/Security Release.md new file mode 100644 index 000000000..cbaf81277 --- /dev/null +++ b/.gitlab/merge_request_templates/Security Release.md @@ -0,0 +1,37 @@ +<!-- +# README first! +This MR should be created on `gitlab.com/gitlab-org/security/gitaly`. + +See [the general developer security release guidelines](https://gitlab.com/gitlab-org/release/docs/blob/master/general/security/developer.md). + +--> + +## Related issues + +<!-- Mention the GitLab Security issue this MR is related to --> + +## Developer checklist + +- [ ] **On "Related issues" section, write down the [GitLab Security] issue it belongs to (i.e. `Related to <issue_id>`).** +- [ ] Merge request targets `master`, or `X-Y-stable` for backports. +- [ ] Milestone is set for the version this merge request applies to. A closed milestone can be assigned via [quick actions]. +- [ ] Title of this merge request is the same as for all backports. +- [ ] A [CHANGELOG entry](https://docs.gitlab.com/ee/development/changelog.html) is added without a `merge_request` value, with `type` set to `security` +- [ ] Assign to a reviewer and maintainer, per our [Code Review process]. +- [ ] For the MR targeting `master`: + - [ ] Ensure it's approved according to our [Approval Guidelines]. +- [ ] Merge request _must not_ close the corresponding security issue, _unless_ it targets `master`. + +**Note:** Reviewer/maintainer should not be a Release Manager + +## Maintainer checklist +- [ ] Correct milestone is applied and the title is matching across all backports +- [ ] Assigned to `@gitlab-release-tools-bot` with passing CI pipelines and **when all backports including the MR targeting master are ready.** + +/label ~security + +[GitLab Security]: https://gitlab.com/gitlab-org/security/gitlab +[approval guidelines]: https://docs.gitlab.com/ee/development/code_review.html#approval-guidelines +[Code Review process]: https://docs.gitlab.com/ee/development/code_review.html +[quick actions]: https://docs.gitlab.com/ee/user/project/quick_actions.html#quick-actions-for-issues-merge-requests-and-epics + |