Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>2021-02-25 13:33:04 +0300
committerÆvar Arnfjörð Bjarmason <avarab@gmail.com>2021-02-25 14:59:04 +0300
commit100fb6668c0b80b90a20c6508eba8efe5a7ece17 (patch)
treeb4c22e3e324c63d7019bb5d0a9d986f14e433cc9 /.gitlab
parent938a75444ca047ce99abf0faf97f1062b6ffcf8d (diff)
Feature flag rollout docs: clarify doc & checklist WRT removal steps
It wasn't clear from the existing checklist item added in 2d9d7f9c9 (Add roll out issue template, 2019-06-11) what the removal steps are, and what "remove feature flag" meant. Split this up into steps where we discuss the removal from the codebase, and what changelog entries we expect there, and then discuss how to remove the feature via chatops.
Diffstat (limited to '.gitlab')
-rw-r--r--.gitlab/issue_templates/Feature Flag Roll Out.md4
1 files changed, 3 insertions, 1 deletions
diff --git a/.gitlab/issue_templates/Feature Flag Roll Out.md b/.gitlab/issue_templates/Feature Flag Roll Out.md
index da2732616..58732b493 100644
--- a/.gitlab/issue_templates/Feature Flag Roll Out.md
+++ b/.gitlab/issue_templates/Feature Flag Roll Out.md
@@ -61,7 +61,9 @@ If applicable, any groups/projects that are happy to have this feature turned on
- [ ] Submit a MR to have the feature `OnByDefault: true` and add changelog entry ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#feature-lifecycle-after-it-is-live))
- [ ] Have that MR merged
- [ ] Possibly wait for at least one deployment cycle ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#two-phase-ruby-to-go-rollouts))
-- [ ] Remove feature flag and add changelog entry
+- [ ] Submit an MR to remove the pre-feature code from the codebase and add changelog entry ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#feature-lifecycle-after-it-is-live))
+- [ ] Have that MR merged
+- [ ] Remove the feature flag via chatops ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#remove-the-feature-flag-via-chatops))
- [ ] Close this issue
/label ~"devops::create" ~"group::gitaly" ~"feature flag" ~"feature::maintainance" ~"Category:Gitaly" ~"section::dev" ~"featureflag::disabled"