diff options
| author | Paul Okstad <pokstad@gitlab.com> | 2021-03-03 21:43:56 +0300 |
|---|---|---|
| committer | Paul Okstad <pokstad@gitlab.com> | 2021-03-03 21:43:56 +0300 |
| commit | d90f745f70d83f45cbc4a2130b3e7d44bfd7e2f6 (patch) | |
| tree | 3274a0a5959bc31606a1bd7f10bff3b70681949d /.gitlab | |
| parent | 7a7763304b57c5c5e66b1083b6407ef576017d73 (diff) | |
Add instructions for verifying feature flag enablement
Diffstat (limited to '.gitlab')
| -rw-r--r-- | .gitlab/issue_templates/Feature Flag Roll Out.md | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/.gitlab/issue_templates/Feature Flag Roll Out.md b/.gitlab/issue_templates/Feature Flag Roll Out.md index 58732b493..c3a3b2968 100644 --- a/.gitlab/issue_templates/Feature Flag Roll Out.md +++ b/.gitlab/issue_templates/Feature Flag Roll Out.md @@ -52,10 +52,12 @@ If applicable, any groups/projects that are happy to have this feature turned on - [ ] Do we need to create a [change management issue](https://about.gitlab.com/handbook/engineering/infrastructure/change-management/#feature-flags-and-the-change-management-process)? ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#do-we-need-a-change-management-issue)) - [ ] Enable on staging ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#enable-on-staging)) - [ ] Test on staging ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#test-on-staging)) +- [ ] Verify the feature flag was used by checking Prometheus metric [`gitaly_feature_flag_checks_total`](https://prometheus.gstg.gitlab.net/graph?g0.expr=sum%20by%20(flag)%20(rate(gitaly_feature_flag_checks_total%5B5m%5D))&g0.tab=1&g0.stacked=0&g0.range_input=1h) - [ ] Announce on this issue an estimated time this will be enabled on GitLab.com - [ ] Add ~"featureflag::production" to this issue - [ ] Enable on GitLab.com by running chatops command in `#production` ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#enable-in-production)) - [ ] Cross post chatops slack command to `#support_gitlab-com` and in your team channel +- [ ] Verify the feature flag is being used by checking Prometheus metric [`gitaly_feature_flag_checks_total`](https://prometheus.gprd.gitlab.net/graph?g0.expr=sum%20by%20(flag)%20(rate(gitaly_feature_flag_checks_total%5B5m%5D))&g0.tab=1&g0.stacked=0&g0.range_input=1h) - [ ] Announce on the issue that the flag has been enabled - [ ] Did you set the feature to both `100%` **and** `true` ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#enable-in-production)) - [ ] Submit a MR to have the feature `OnByDefault: true` and add changelog entry ([howto](https://gitlab.com/gitlab-org/gitaly/-/blob/master/doc/PROCESS.md#feature-lifecycle-after-it-is-live)) |