diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-15 20:24:43 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-19 09:42:03 +0300 |
| commit | b2dea641c2a414d97ebd10749d29837ddc971410 (patch) | |
| tree | 7344873c6f3ffe400892f82549e3871bcc390981 /.golangci.yml | |
| parent | d416881b525fafea5135a6963215e70009cb282f (diff) | |
repository: Fix silent error if sending GetInfoAttributes response fails
If `GetInfoAttributes()` doesn't have to do anything because there is no
gitattributes file, then we simply bail out and send a successful
response. We do not verify that sending the response succeeds though,
which could lead to us silently swallowing the error.
Fix the issue by returning the error of `stream.Send()` and drop the
corresponding linter ignore rule.
Diffstat (limited to '.golangci.yml')
| -rw-r--r-- | .golangci.yml | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/.golangci.yml b/.golangci.yml index d2607d910..e9faf18bf 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -767,10 +767,6 @@ issues: text: "Error return value of `s.checkNodes` is not checked" - linters: - errcheck - path: "internal/gitaly/service/repository/info_attributes.go" - text: "Error return value of `stream.Send` is not checked" - - linters: - - errcheck path: "internal/gitaly/service/repository/snapshot.go" text: "Error return value of `builder.FileIfExist` is not checked" - linters: |