diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-15 21:11:15 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-19 09:48:29 +0300 |
| commit | 409e934a5a1c7473b2447fbb73120af5b7738f07 (patch) | |
| tree | 321e4913efc30a57fc80268218f470cbcdae2a17 /.golangci.yml | |
| parent | e4b922e087a10a99047d20311f6e5d1b0bdda56b (diff) | |
pktline: Verify writing pktlines succeeds
Our tests are missing various error checks when writing pktline
formatted data. Fix this by adding a set of wrappers which do the error
checking for us and drop the corresponding linter ignore rules.
Diffstat (limited to '.golangci.yml')
| -rw-r--r-- | .golangci.yml | 9 |
1 files changed, 0 insertions, 9 deletions
diff --git a/.golangci.yml b/.golangci.yml index d753f4330..8ea357058 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -841,11 +841,6 @@ issues: - errcheck path: "internal/supervisor/supervisor_test.go" text: "Error return value of `syscall\\.Kill` is not checked" - ## errcheck: General (wide) rules in *_test.go files - - linters: - - errcheck - path: "_test.go" - text: "Error return value of `pktline.Write(String|Flush)` is not checked" ## errcheck: Specific issues in *_test.go files - linters: - errcheck @@ -857,10 +852,6 @@ issues: text: "Error return value of `cmd.Process.Kill` is not checked" - linters: - errcheck - path: "internal/gitaly/service/smarthttp/upload_pack_test.go" - text: "Error return value of `pktline.WriteDelim` is not checked" - - linters: - - errcheck path: "internal/middleware/sentryhandler/sentryhandler_test.go" text: "Error return value is not checked" - linters: |