diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-06-09 19:23:56 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-06-14 08:52:34 +0300 |
| commit | 603058f365a004240e3e3badf9596f9f9c49baa5 (patch) | |
| tree | 9802beb35bb5307240cdb732c4b88391d000c2cd /.golangci.yml | |
| parent | 68195ae01164e62e3d92156ec84e09c7416e3f94 (diff) | |
stats: Refactor the `Get` structure
The `Get` structure hosts statistics about a GET request against
git-upload-pack(1). Without knowing details about how git-upload-pack(1)
works though, one wouldn't be able to tell what it actually represents:
everything related to the reference discovery.
Let's rename the structure to `HTTPReferenceDiscovery`, which more
clearly labels what it actually is about. While at it, this also
refactors the way it's constructed: instead of being constructed via the
`Clone` structure, it's now a standalone structure and can be
constructed via `performReferenceDiscovery()`. This disentangles
concerns and makes it easier to reason about the code.
Diffstat (limited to '.golangci.yml')
| -rw-r--r-- | .golangci.yml | 20 |
1 files changed, 0 insertions, 20 deletions
diff --git a/.golangci.yml b/.golangci.yml index d6475eb0e..182a85533 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -289,26 +289,6 @@ issues: text: "exported type `Clone` should have comment or be unexported" - linters: - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported type `Get` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Get.ResponseHeader` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Get.HTTPStatus` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Get.FirstGitPacket` should have comment or be unexported" - - linters: - - golint - path: "internal/git/stats/analyzehttp.go" - text: "exported method `Get.ResponseBody` should have comment or be unexported" - - linters: - - golint path: "internal/git/stats/packfile_negotiation.go" text: "exported type `PackfileNegotiation` should have comment or be unexported" - linters: |