diff options
author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-11-11 15:50:17 +0300 |
---|---|---|
committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-11-12 17:39:42 +0300 |
commit | f80312d8cd9547daee0d6c0a2bb3f477fc2ee1d9 (patch) | |
tree | 4aa9775689dffcc8be6231f69b7408f9cebd98a6 /.golangci.yml | |
parent | 535484153103e4706439e39015c7852da2d14531 (diff) |
repository: Remove deprecated and unused fields from GetRawChanges
The "old_path" and "new_path" fields of the GetRawChanges responses have
been deprecated ever since we have moved the protobuf definitions into
our repo in b9c9aec5c (Start preparation for migrating .proto files,
2019-07-05). They had originally been deprecated given that they were
using strings as types, and invalid Unicode characters in strings get
dropped when serializing and deserializing Protobuf messages. They had
thus been replaced with two fields "old_path_bytes" and "new_path_bytes"
and downstream callers have long been converted to use these.
Let's drop the old and deprecated fields -- they're not used by
anything, and neither should they ever be used.
Diffstat (limited to '.golangci.yml')
-rw-r--r-- | .golangci.yml | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/.golangci.yml b/.golangci.yml index 54f068ed3..1ed846a01 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -702,14 +702,6 @@ issues: text: "Error return value of `strategy.checkNodes` is not checked" ## END errcheck exclusions ## - ## BEGIN staticcheck exclusions - - linters: - - staticcheck - text: "resp.OldPath is deprecated" - - linters: - - staticcheck - text: "resp.NewPath is deprecated" - ## END staticcheck exclusions # govet checks all struct initializations must be keyed by field names - linters: - stylecheck |