diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-15 20:45:51 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-19 09:45:33 +0300 |
| commit | 08a45f1512cd58ad8ed2e2a5b2b4d8f0f604ad89 (patch) | |
| tree | 6219e6d26049dff78ffbc7cc8eac74e941717e55 /.golangci.yml | |
| parent | f0e4f5be269148443363efa4ec238c6802816722 (diff) | |
proxy: Verify sending GRPC data succeeds
The proxy tests are missing error checking for various GRPC functions,
which may easily hide unexpected errors. Fix the issue and remove
corresponding linter ignore rules.
Diffstat (limited to '.golangci.yml')
| -rw-r--r-- | .golangci.yml | 24 |
1 files changed, 0 insertions, 24 deletions
diff --git a/.golangci.yml b/.golangci.yml index e11f73e0a..6c3c8c74d 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -857,30 +857,6 @@ issues: text: "Error return value of `cmd.Process.Kill` is not checked" - linters: - errcheck - path: "internal/praefect/grpc-proxy/proxy/handler_test.go" - text: "Error return value of `grpc.SendHeader` is not checked" - - linters: - - errcheck - path: "internal/praefect/grpc-proxy/proxy/handler_test.go" - text: "Error return value of `grpc.SetTrailer` is not checked" - - linters: - - errcheck - path: "internal/praefect/grpc-proxy/proxy/handler_test.go" - text: "Error return value of `stream.SendHeader` is not checked" - - linters: - - errcheck - path: "internal/praefect/grpc-proxy/proxy/handler_test.go" - text: "Error return value of `stream.Send` is not checked" - - linters: - - errcheck - path: "internal/praefect/grpc-proxy/proxy/handler_test.go" - text: "Error return value of `stream.SendHeader` is not checked" - - linters: - - errcheck - path: "internal/praefect/grpc-proxy/proxy/peeker_test.go" - text: "Error return value of `proxyClientPingStream.CloseSend` is not checked" - - linters: - - errcheck path: "internal/bootstrap/bootstrap_test.go" text: "Error return value of `server.server.Shutdown` is not checked" - linters: |