locator: Return proper error code if repo paths do not exist

When retrieving the path of a repository via `GetPath()`, we call
stat(3P) on the calculated path in order to determine whether the
repository exists or not. In case the stat(3P) call errors, we always
return an internal code. This isn't ideal though: while the error may be
because of whatever reason, the most likely reason is that the target
path simply doesn't exist. Returning an internal code is not ideal in
that case.

Fix the issue by returning a `NotFound` code in case the error returned
by stat(3P) is ENOENT.

2 files changed, 4 insertions, 1 deletions

diff --git a/internal/gitaly/config/locator.go b/internal/gitaly/config/locator.go
index a06ad4e8a..a5fdea3c5 100644
--- a/internal/gitaly/config/locator.go
+++ b/internal/gitaly/config/locator.go
@@ -52,6 +52,9 @@ func (l *configLocator) GetPath(repo repository.GitRepo) (string, error) {
 	}
 
 	if _, err := os.Stat(storagePath); err != nil {
+		if os.IsNotExist(err) {
+			return "", status.Errorf(codes.NotFound, "GetPath: does not exist: %v", err)
+		}
 		return "", status.Errorf(codes.Internal, "GetPath: storage path: %v", err)
 	}
 
diff --git a/internal/gitaly/service/repository/repository_test.go b/internal/gitaly/service/repository/repository_test.go
index dc24e2d5e..22db3659a 100644
--- a/internal/gitaly/service/repository/repository_test.go
+++ b/internal/gitaly/service/repository/repository_test.go
@@ -101,7 +101,7 @@ func TestRepositoryExists(t *testing.T) {
 					RelativePath: "foobar.git",
 				},
 			},
-			errorCode: codes.Internal,
+			errorCode: codes.NotFound,
 		},
 	}