diff options
| author | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2020-09-18 10:13:23 +0300 |
|---|---|---|
| committer | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2020-09-18 10:13:23 +0300 |
| commit | b5937b10d1a386c392adb1ebced2d0c8cb038696 (patch) | |
| tree | 435fe71ee8f8362846453349ac6bc0aaf10145af | |
| parent | 3fb96c945c7366683af2fe5496e1dd5628e70820 (diff) | |
| parent | 359f68d16abbc39d897b9ddadadc6178ab42d029 (diff) | |
Merge branch 'po-config-change-deprecation' into 'master'
Add deprecation notes to config change issue template
See merge request gitlab-org/gitaly!2574
| -rw-r--r-- | .gitlab/issue_templates/Config Change.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/.gitlab/issue_templates/Config Change.md b/.gitlab/issue_templates/Config Change.md index 555ae7062..be255ca2a 100644 --- a/.gitlab/issue_templates/Config Change.md +++ b/.gitlab/issue_templates/Config Change.md @@ -1,9 +1,10 @@ # Gitaly/Praefect configuration change checklist -There are a number of projects which depend on Gitaly's or Praefect's configuration. When you change the configuration, please have a look whether the change needs to be propagated to any of the listed projects. +There are a number of projects which depend on Gitaly's or Praefect's configuration. When you change the configuration, please have a look whether the change needs to be propagated to any of the listed projects. If deprecating or removing a configuration, consult the [configuration deprecation policy](https://docs.gitlab.com/omnibus/package-information/deprecation_policy.html#deprecating-configuration). 1. [ ] Update the example configuration files for [Gitaly](https://gitlab.com/gitlab-org/gitaly/-/blob/master/config.toml.example) and [Praefect](https://gitlab.com/gitlab-org/gitaly/-/blob/master/config.praefect.toml.example) 1. [ ] Update in [omnibus-gitlab](https://gitlab.com/gitlab-org/omnibus-gitlab) the configuration templates for [Gitaly](https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/master/files/gitlab-cookbooks/gitaly/templates/default/gitaly-config.toml.erb) and [Praefect](https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/master/files/gitlab-cookbooks/praefect/templates/default/praefect-config.toml.erb): `<MR LINK>` + - [ ] If deprecating or removing a configuration, consider adding a [deprecation notice](https://gitlab.com/gitlab-org/omnibus-gitlab/-/blob/master/files/gitlab-cookbooks/package/libraries/deprecations.rb). 1. [ ] Update in [gitlab-development-kit](https://gitlab.com/gitlab-org/gitlab-development-kit) the configuration templates for [Gitaly](https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/master/support/templates/gitaly.config.toml.erb) and [Praefect](https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/master/support/templates/praefect.config.toml.erb): `<MR LINK>` 1. [ ] Update in [GitLab Chart](https://gitlab.com/gitlab-org/charts/gitlab) the configuration template for [Gitaly](https://gitlab.com/gitlab-org/charts/gitlab/-/blob/master/charts/gitlab/charts/gitaly/templates/configmap.yml): `<MR LINK>` 1. [ ] Update in [CNG](https://gitlab.com/gitlab-org/build/CNG) the [development configuration for Gitaly](https://gitlab.com/gitlab-org/build/CNG/-/blob/master/dev/gitaly-config/config.toml) and the [default configuration for Gitaly](https://gitlab.com/gitlab-org/build/CNG/-/blob/master/gitaly/config.toml): `<MR LINK>` |