diff options
author | Pavlo Strokov <pstrokov@gitlab.com> | 2021-10-06 13:50:00 +0300 |
---|---|---|
committer | Pavlo Strokov <pstrokov@gitlab.com> | 2021-10-08 12:14:48 +0300 |
commit | 07e2697b59d8fd3bd928b6b2135dddba53b64315 (patch) | |
tree | fea53306bf0b3ad7c9504311f51690a7e6d3683a | |
parent | 062a7df6c352c59acf33924b4e57ebc00bda4054 (diff) |
test: Database name extraction is not needed
Code simplified to use a field of the glsql.DB struct
instead of extracting database name directly with SQL.
-rw-r--r-- | cmd/praefect/subcmd_remove_repository_test.go | 8 | ||||
-rw-r--r-- | cmd/praefect/subcmd_track_repository_test.go | 4 | ||||
-rw-r--r-- | internal/backup/backup_test.go | 4 | ||||
-rw-r--r-- | internal/praefect/repocleaner/repository_test.go | 8 |
4 files changed, 6 insertions, 18 deletions
diff --git a/cmd/praefect/subcmd_remove_repository_test.go b/cmd/praefect/subcmd_remove_repository_test.go index 9dab2f0a6..05e5de779 100644 --- a/cmd/praefect/subcmd_remove_repository_test.go +++ b/cmd/praefect/subcmd_remove_repository_test.go @@ -66,9 +66,7 @@ func TestRemoveRepository_Exec_invalidArgs(t *testing.T) { t.Run("praefect address is not set in config ", func(t *testing.T) { cmd := removeRepository{virtualStorage: "stub", relativePath: "stub", logger: testhelper.NewTestLogger(t)} db := glsql.NewDB(t) - var database string - require.NoError(t, db.QueryRow(`SELECT current_database()`).Scan(&database)) - dbConf := glsql.GetDBConfig(t, database) + dbConf := glsql.GetDBConfig(t, db.Name) err := cmd.Exec(flag.NewFlagSet("", flag.PanicOnError), config.Config{DB: dbConf}) require.EqualError(t, err, "get praefect address from config: no Praefect address configured") }) @@ -83,9 +81,7 @@ func TestRemoveRepository_Exec(t *testing.T) { g2Srv := testserver.StartGitalyServer(t, g2Cfg, nil, setup.RegisterAll, testserver.WithDisablePraefect()) db := glsql.NewDB(t) - var database string - require.NoError(t, db.QueryRow(`SELECT current_database()`).Scan(&database)) - dbConf := glsql.GetDBConfig(t, database) + dbConf := glsql.GetDBConfig(t, db.Name) conf := config.Config{ SocketPath: testhelper.GetTemporaryGitalySocketFileName(t), diff --git a/cmd/praefect/subcmd_track_repository_test.go b/cmd/praefect/subcmd_track_repository_test.go index c03329eb1..4f03576ed 100644 --- a/cmd/praefect/subcmd_track_repository_test.go +++ b/cmd/praefect/subcmd_track_repository_test.go @@ -83,9 +83,7 @@ func TestAddRepository_Exec(t *testing.T) { g1Addr := g1Srv.Address() db := glsql.NewDB(t) - var database string - require.NoError(t, db.QueryRow(`SELECT current_database()`).Scan(&database)) - dbConf := glsql.GetDBConfig(t, database) + dbConf := glsql.GetDBConfig(t, db.Name) virtualStorageName := "praefect" conf := config.Config{ diff --git a/internal/backup/backup_test.go b/internal/backup/backup_test.go index 059f9267c..2a5ef60e1 100644 --- a/internal/backup/backup_test.go +++ b/internal/backup/backup_test.go @@ -152,9 +152,7 @@ func TestManager_Restore_praefect(t *testing.T) { gitalyAddr := testserver.RunGitalyServer(t, gitalyCfg, nil, setup.RegisterAll, testserver.WithDisablePraefect()) db := glsql.NewDB(t) - var database string - require.NoError(t, db.QueryRow(`SELECT current_database()`).Scan(&database)) - dbConf := glsql.GetDBConfig(t, database) + dbConf := glsql.GetDBConfig(t, db.Name) conf := praefectConfig.Config{ SocketPath: testhelper.GetTemporaryGitalySocketFileName(t), diff --git a/internal/praefect/repocleaner/repository_test.go b/internal/praefect/repocleaner/repository_test.go index 31f20b30c..4cbed8cae 100644 --- a/internal/praefect/repocleaner/repository_test.go +++ b/internal/praefect/repocleaner/repository_test.go @@ -49,9 +49,7 @@ func TestRunner_Run(t *testing.T) { g3Addr := testserver.RunGitalyServer(t, g3Cfg, nil, setup.RegisterAll, testserver.WithDisablePraefect()) db := glsql.NewDB(t) - var database string - require.NoError(t, db.QueryRow(`SELECT current_database()`).Scan(&database)) - dbConf := glsql.GetDBConfig(t, database) + dbConf := glsql.GetDBConfig(t, db.Name) conf := config.Config{ SocketPath: testhelper.GetTemporaryGitalySocketFileName(t), @@ -207,9 +205,7 @@ func TestRunner_Run_noAvailableStorages(t *testing.T) { g1Addr := testserver.RunGitalyServer(t, g1Cfg, nil, setup.RegisterAll, testserver.WithDisablePraefect()) db := glsql.NewDB(t) - var database string - require.NoError(t, db.QueryRow(`SELECT current_database()`).Scan(&database)) - dbConf := glsql.GetDBConfig(t, database) + dbConf := glsql.GetDBConfig(t, db.Name) conf := config.Config{ SocketPath: testhelper.GetTemporaryGitalySocketFileName(t), |