Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNick Thomas <nick@gitlab.com>2018-07-31 19:35:25 +0300
committerNick Thomas <nick@gitlab.com>2019-01-07 19:07:01 +0300
commit7a469fa6841be9c2e69855c9d4e6f853e34b618a (patch)
tree22655280f40771ee7c96933e6bb6f3a4c7d34b7b
parentdd7b92f17d2508a91259641f132c8ed23be1e9ea (diff)
Fix logging of RenameNamespace RPC parameters
-rw-r--r--changelogs/unreleased/1302-fix-rename-namespace-rpc-logging.yml5
-rw-r--r--internal/helper/fieldextractors/fieldextractor.go5
2 files changed, 8 insertions, 2 deletions
diff --git a/changelogs/unreleased/1302-fix-rename-namespace-rpc-logging.yml b/changelogs/unreleased/1302-fix-rename-namespace-rpc-logging.yml
new file mode 100644
index 000000000..add78ad2b
--- /dev/null
+++ b/changelogs/unreleased/1302-fix-rename-namespace-rpc-logging.yml
@@ -0,0 +1,5 @@
+---
+title: Fix logging of RenameNamespace RPC parameters
+merge_request: 847
+author:
+type: fixed
diff --git a/internal/helper/fieldextractors/fieldextractor.go b/internal/helper/fieldextractors/fieldextractor.go
index fa57328e8..cb8f5aeca 100644
--- a/internal/helper/fieldextractors/fieldextractor.go
+++ b/internal/helper/fieldextractors/fieldextractor.go
@@ -63,7 +63,7 @@ func formatNamespaceRequest(namespaceReq namespaceBasedRequest) map[string]inter
}
}
-func formatRenameNamespaceRequest(renameReq gitalypb.RenameNamespaceRequest) map[string]interface{} {
+func formatRenameNamespaceRequest(renameReq *gitalypb.RenameNamespaceRequest) map[string]interface{} {
return map[string]interface{}{
"StorageName": renameReq.GetStorageName(),
"From": renameReq.GetFrom(),
@@ -78,8 +78,9 @@ func FieldExtractor(fullMethod string, req interface{}) map[string]interface{} {
}
var result map[string]interface{}
+
switch req := req.(type) {
- case gitalypb.RenameNamespaceRequest:
+ case *gitalypb.RenameNamespaceRequest:
result = formatRenameNamespaceRequest(req)
case repositoryBasedRequest:
result = formatRepoRequest(req.GetRepository())